-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format try statements. #1332
Format try statements. #1332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, especially the tests. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
@srawlins If you could help me look at this for readability (so I can add this as a contribution haha), that'd be great. Thank you :) Sending to Sam for readability comments. Please review as a readability CL and add your feedback at go/dart-team-readability-feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for readability
TryPiece
for try statements. They are very similar to if statements, but I kept them separate.TryPiece
has one or more_TrySectionPiece
which is a catch or finally header and block. They're all formatted similarly.Will also remove the temp dir tests after submission.
(I'll send this over to Nate for readability after approval :D )