Allow a factory constructor with metadata before it to split. #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, if there was metadata before a constructor, it would be attached to the "header" piece of the constructor -- the leading keywords and name -- instead of the entire constructor piece. That in turn meant that the newline after the metadata would lead the formatter to think a split had occurred inside the header itself, instead of before the entire constructor. That would in turn confuse the solver and it ended up trying to disallow splitting anywhere in the constructor, even if that led to an overflowing line. This fixes that so that the metadata is attached to the entire constructor piece, not just the nested header part.
natebosch
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if there was metadata before a constructor, it would be attached to the "header" piece of the constructor -- the leading keywords and name -- instead of the entire constructor piece.
That in turn meant that the newline after the metadata would lead the formatter to think a split had occurred inside the header itself, instead of before the entire constructor. That would in turn confuse the solver and it ended up trying to disallow splitting anywhere in the constructor, even if that led to an overflowing line.
This fixes that so that the metadata is attached to the entire constructor piece, not just the nested header part.