Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a list of include paths in analysis options #1594

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Nov 5, 2024

Fixes #1591

The implementation is fairly simple. If the include value in an analysis options file is a List, then iteratively merge included options files.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

test/utils.dart Outdated
var yaml = StringBuffer();

if (include != null) {
if (include is String) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: How about a switch here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@munificent munificent merged commit ecfc0cb into dart-lang:main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support determining the page_width given a list / lists of multiple included files
2 participants