Declare local variables for the 'href' field, to promote and avoid pr…

…inting 'null'
dart-lang · Jun 17, 2024 · a3d519b · a3d519b
1 parent 14d33d3
commit a3d519b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/lib/src/markdown_processor.dart b/lib/src/markdown_processor.dart
@@ -314,15 +314,13 @@ class MarkdownDocument extends md.Document {
     var textContent = _htmlEscape.convert(referenceText);
     var linkedElement = result.commentReferable;
     if (linkedElement != null) {
-      if (linkedElement.href != null) {
-        var anchor = md.Element.text('a', textContent);
+      var href = linkedElement.href;
+      if (href != null) {
+        var anchor = md.Element.text('a', textContent)
+          ..attributes['href'] = href;
         if (linkedElement is ModelElement && linkedElement.isDeprecated) {
           anchor.attributes['class'] = 'deprecated';
         }
-        var href = linkedElement.href;
-        if (href != null) {
-          anchor.attributes['href'] = href;
-        }
         return anchor;
       } else {
         // Otherwise this would be `linkedElement.linkedName`, but link bodies

diff --git a/lib/src/model/category.dart b/lib/src/model/category.dart
@@ -143,6 +143,11 @@ class Category
   String get linkedName {
     final unbrokenName = name.replaceAll(' ', '&nbsp;');
     if (isDocumented) {
+      final href = this.href;
+      if (href == null) {
+        throw StateError("Requesting the 'linkedName' of a non-canonical "
+            "category: '$name'");
+      }
       return '<a href="$href">$unbrokenName</a>';
     } else {
       return unbrokenName;

diff --git a/lib/src/model/model_element.dart b/lib/src/model/model_element.dart
@@ -687,6 +687,7 @@ abstract class ModelElement
         element.kind == ElementKind.NEVER ||
         this is ModelFunction);
 
+    final href = this.href;
     if (href == null) {
       if (isPublicAndPackageDocumented) {
         warn(PackageWarning.noCanonicalFound);