Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with extension members and unfound doc comment references #3811

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Jul 3, 2024

Fixes #3808

The main issue is that #3805 changed how extension accessors and "fields" (the synthetic ones introduced by accessors) are instantiated. This tidies up a few places related to that. The main thrust of this is in container_member.dart, where we prefer the canonical element of a field's getter/setter, rather than the canonical element of the field, which can introduce a weird side effect of stranded accessors without an "enclosingCombo" of the field.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

srawlins commented Jul 8, 2024

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit 5e8de16 into dart-lang:main Jul 8, 2024
9 checks passed
@srawlins srawlins deleted the fix-sdk branch July 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure rolling into the dart sdk repo
2 participants