Fix issue with extension members and unfound doc comment references #3811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3808
The main issue is that #3805 changed how extension accessors and "fields" (the synthetic ones introduced by accessors) are instantiated. This tidies up a few places related to that. The main thrust of this is in
container_member.dart
, where we prefer the canonical element of a field's getter/setter, rather than the canonical element of the field, which can introduce a weird side effect of stranded accessors without an "enclosingCombo" of the field.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.