Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have firehose create urls to the github release page #97

Open
devoncarew opened this issue May 9, 2023 · 1 comment
Open

have firehose create urls to the github release page #97

devoncarew opened this issue May 9, 2023 · 1 comment
Labels
package:firehose type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

Have firehose create urls to the github release page; the url could be pre-populated w/ the release tag, changelog info, ...
@devoncarew devoncarew added type-enhancement A request for a change that isn't a bug package:firehose labels May 9, 2023
@jakemac53
Copy link
Contributor

#98 provides a V1 of this, but I think we could use a follow up at some point:

  • Only make the tag a link to create the release once it is merged to reduce mistakes
  • If we do that, then we can also specify the exact commit sha for the tag, which will help eliminate race conditions in the case that another PR lands before somebody actually creates the release.

jakemac53 added a commit that referenced this issue May 9, 2023
@jakemac53
make publish tags link to the release page with populated fields (#98)
3163b3b 
V1 of #97

Updates the markdown table so that "publish tag" tags are links to a release page with all the information pre-populated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:firehose type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @devoncarew