-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'unnecessary_library_name' to package:dart_flutter_team_lints #252
Conversation
PR HealthBreaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
dart_flutter_team_lints | Breaking | 3.0.0 | 3.1.0 | 4.0.0 Got "3.1.0" expected >= "4.0.0" (breaking changes) |
|
firehose | None | 0.9.0 | 0.9.0 | 0.9.0 | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check
.
Changelog Entry ❗
Details
Package | Changed Files |
---|---|
package:firehose | pkgs/firehose/pubspec.yaml |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check
.
Coverage ✔️
Details
File | Coverage |
---|
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks ✔️
Details
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Package publish validation ✔️
Details
Package | Version | Status |
---|---|---|
package:dart_flutter_team_lints | 3.1.0 | ready to publish |
package:firehose | 0.9.0 | already published at pub.dev |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
From the CI failures, we'd need to bump the min. sdk to 3.4 (not yet published to stable) for |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
…ce_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, tools, typed_data, watcher, web, web_socket_channel, webdev, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/5890417..ad9da15): ad9da15 2024-05-13 Devon Carew add 'unnecessary_library_name' to package:dart_flutter_team_lints (dart-lang/ecosystem#252) http (https://github.com/dart-lang/http/compare/fdb0d36..4722e03): 4722e03 2024-05-14 Brian Quinlan Prepare http_profile for publish (dart-lang/http#1197) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/4671c20..6834af5): 6834af5 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/source_map_stack_trace#54) f356e62 2024-05-13 Devon Carew blast_repo fixes (dart-archive/source_map_stack_trace#53) source_maps (https://github.com/dart-lang/source_maps/compare/c4dc7d0..181a41c): 181a41c 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/source_maps#93) a3d7c5c 2024-05-13 Devon Carew blast_repo fixes (dart-lang/source_maps#92) source_span (https://github.com/dart-lang/source_span/compare/1695904..e80cb44): e80cb44 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/source_span#112) c2743b4 2024-05-13 Devon Carew blast_repo fixes (dart-lang/source_span#111) sse (https://github.com/dart-lang/sse/compare/f5ed4d6..1bb0a98): 1bb0a98 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/sse#110) 184d72e 2024-05-13 Devon Carew blast_repo fixes (dart-lang/sse#109) stack_trace (https://github.com/dart-lang/stack_trace/compare/54c7b9d..4d346f7): 4d346f7 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/stack_trace#154) 2b053bf 2024-05-13 Devon Carew blast_repo fixes (dart-lang/stack_trace#153) stream_channel (https://github.com/dart-lang/stream_channel/compare/ba35137..61ad872): 61ad872 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/stream_channel#106) 73746a0 2024-05-13 Devon Carew blast_repo fixes (dart-lang/stream_channel#105) string_scanner (https://github.com/dart-lang/string_scanner/compare/6e893af..32468bd): 32468bd 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/string_scanner#74) 395dc7e 2024-05-13 Devon Carew blast_repo fixes (dart-lang/string_scanner#73) term_glyph (https://github.com/dart-lang/term_glyph/compare/c3e323b..a46b48b): a46b48b 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/term_glyph#52) cc75160 2024-05-13 Devon Carew blast_repo fixes (dart-lang/term_glyph#51) tools (https://github.com/dart-lang/tools/compare/d35d633..86b3661): 86b3661 2024-05-13 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/tools#270) 760015a 2024-05-13 Devon Carew blast_repo fixes (dart-lang/tools#269) typed_data (https://github.com/dart-lang/typed_data/compare/5b3708e..fb1958c): fb1958c 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/typed_data#87) 9c4cb6f 2024-05-13 Devon Carew blast_repo fixes (dart-archive/typed_data#86) watcher (https://github.com/dart-lang/watcher/compare/42308ea..c182cd3): c182cd3 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/watcher#167) c7e8d2c 2024-05-13 Devon Carew blast_repo fixes (dart-lang/watcher#166) web (https://github.com/dart-lang/web/compare/c36d962..d776645): d776645 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/web#238) a59e8b4 2024-05-13 Devon Carew blast_repo fixes (dart-lang/web#237) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/5f65bae..8c77d6f): 8c77d6f 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/web_socket_channel#360) 758148c 2024-05-13 Devon Carew blast_repo fixes (dart-lang/web_socket_channel#359) webdev (https://github.com/dart-lang/webdev/compare/9108903..d46cf50): d46cf50e 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/webdev#2434) 86a8502e 2024-05-13 Devon Carew blast_repo fixes (dart-lang/webdev#2433) yaml (https://github.com/dart-lang/yaml/compare/022ea64..8fb8147): 8fb8147 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/yaml#164) 620e34b 2024-05-13 Devon Carew blast_repo fixes (dart-lang/yaml#163) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/c4629ad..3191934): 3191934 2024-05-13 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/yaml_edit#79) 7dbc61d 2024-05-13 Devon Carew blast_repo fixes (dart-lang/yaml_edit#78) Change-Id: I20a413371e3adc9a53e27e1308eac04753a434f9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366440 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.