New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete pigeon-generated file #1032

Merged

brianquinlan merged 2 commits into dart-lang:master from brianquinlan:rmpigeon

Oct 11, 2023

Collaborator

brianquinlan commented Oct 10, 2023

Remove a file that was generated by Pigeon and is no longer used after the switch to jni.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Remove obsolete pigeon-generated file

ba22320

github-actions bot added the package:cronet_http label

brianquinlan requested a review from HosseinYousefi

October 10, 2023 20:14

HosseinYousefi approved these changes

View reviewed changes

Member

HosseinYousefi left a comment

LGTM! You might want to remove the java file as well: https://github.com/dart-lang/http/blob/master/pkgs/cronet_http/android/src/main/java/io/flutter/plugins/cronet_http/Messages.java


          Remove Java messages

a973464

brianquinlan merged commit 7240d0a into dart-lang:master

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:cronet_http