-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a flutter example application that uses multiple client implementations #1040
Create a flutter example application that uses multiple client implementations #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look at stuff other than the Dart. Consider getting a second review from someone with Flutter experience.
@@ -0,0 +1,5 @@ | |||
# Launch Screen Assets | |||
|
|||
You can customize the launch screen with your own desired assets by replacing the image files in this directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it typical flutter practice to check in these generated files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is checked in in the flutter gallery:
https://github.com/flutter/gallery/blob/fa031bfe9d131010e7a56ee5d343f9f85b367d64/ios/Runner/Assets.xcassets/LaunchImage.imageset/README.md?plain=1#L3
@@ -0,0 +1,155 @@ | |||
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | |
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from pkgs/cupertino_http so I think that this copyright is correct.
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
package:http
including:Client
instances through the appcronet_http
andcupertino_http
examples to match the new application, except where this would increase the complexity too much.flutter create -t app
. Some interesting files:Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.