address review comments

dart-lang · Jan 24, 2018 · cdbe9ce · cdbe9ce
1 parent 6b3d600
commit cdbe9ce
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/src/rules/avoid_shadowing.dart b/lib/src/rules/avoid_shadowing.dart
@@ -78,6 +78,7 @@ class _Visitor extends SimpleAstVisitor {
   @override
   visitVariableDeclarationStatement(VariableDeclarationStatement node) {
     final variables = node.variables.variables;
+    final library = variables.first.element.library;
 
     bool skipInstanceMembers = false;
     AstNode current = node;
@@ -109,11 +110,8 @@ class _Visitor extends SimpleAstVisitor {
       }
 
       current = current.parent;
-      if (current == null) {
-        final library = node.variables.variables.first.element.library;
-        _checkLibrary(library, variables);
-      }
     }
+    _checkLibrary(library, variables);
   }
 
   void _checkClass(

diff --git a/test/rules/avoid_shadowing.dart b/test/rules/avoid_shadowing.dart
@@ -73,3 +73,11 @@ class D {
     var c; // LINT
   }
 }
+
+// 2 shadowing
+class E {
+  int x;
+  m(int x) {
+    int x; // LINT
+  }
+}