-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bogus unnecessary_this with pattern matching and shadowing #4381
Labels
false-positive
P1
A high priority bug; for example, a single project is unusable or has many test failures
set-recommended
Affects a rule in the recommended Dart rule set
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
Comments
srawlins
added
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
P3
A lower priority bug or feature request
labels
May 23, 2023
github-actions
bot
added
set-recommended
Affects a rule in the recommended Dart rule set
labels
May 23, 2023
pq
added
P1
A high priority bug; for example, a single project is unusable or has many test failures
and removed
P3
A lower priority bug or feature request
labels
May 23, 2023
Good catch. Taking a look now. Thanks! |
It looks like the issue is percolating up from analyzer. Tracking in dart-lang/sdk#52486 |
Merged
@pq Is there an ETA on this ending up in a released Dart version? It looks like Dart 3.0.7 is still surfacing the bogus lint. |
nex3
added a commit
to sass/dart-sass
that referenced
this issue
Aug 2, 2023
nex3
added a commit
to sass/dart-sass
that referenced
this issue
Aug 2, 2023
My understanding is that a Dart 3.1 release is slated for the next few weeks. (@itsjustkevin could confirm?) |
nex3
added a commit
to sass/dart-sass
that referenced
this issue
Aug 21, 2023
nex3
added a commit
to sass/dart-sass
that referenced
this issue
Aug 21, 2023
This was referenced Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
false-positive
P1
A high priority bug; for example, a single project is unusable or has many test failures
set-recommended
Affects a rule in the recommended Dart rule set
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
For the code below:
the 3.0.0 analyzer will print
This is incorrect. The
this.
is necessary to disambiguate the containing class'svalue
field from thevalue
variable bound by theswitch
expression.The text was updated successfully, but these errors were encountered: