This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
skip nullable iterables in avoid_function_literals_in_foreach_calls
#2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
changed the title
avoid_function_literals_in_foreach_calls
bwilkerson
approved these changes
Jul 7, 2021
|
|
||
| bool _isNonNullableIterable(DartType? type) => | ||
| type != null && | ||
| type.nullabilitySuffix != NullabilitySuffix.question && |
There was a problem hiding this comment.
I'm not sure how this works for dynamic. Consider
void f(dynamic iter) => iter?.forEach(...);
Is the suffix always a question even when it isn't explicitly given?
I'll just note that an equivalent test might be to look for the ?. operator on the method invocation.
There was a problem hiding this comment.
Is the suffix always a question even when it isn't explicitly given?
I believe so? (@scheglov may knot for sure.)
In any event, I added a dynamic test case and it seems to work as written.
Thanks for the catch!
There was a problem hiding this comment.
The type dynamic is always nullable, and it does not have any nullabilitySuffix, it is always NullabilitySuffix.none. Note that the suffix is not the same as nullability, e.g. FutureOr<int?> is nullable.
7 tasks
This was referenced Oct 24, 2022
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
…dart-lang/linter#4330) Fixes dart-lang/linter#4328. Reverts dart-lang/linter#4039 that caused false negatives in non-null-safe mode. And reverts dart-lang/linter#2752 along with it because it was not the exact right fix in the first place. Null-aware calls are since handled by dart-lang/linter#4305 and all the existing tests still pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #dart-lang/sdk#58444
/cc @bwilkerson