Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

more test diagnostic cleanup #2984

Merged
merged 2 commits into from
Sep 30, 2021
Merged

more test diagnostic cleanup #2984

merged 2 commits into from
Sep 30, 2021

Conversation

pq
Copy link
Member

@pq pq commented Sep 30, 2021

@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@@ -214,32 +215,6 @@ abstract class LintRuleTest extends PubPackageResolutionTest {
fail(buffer.toString());
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm. Looks like I didn't rebase. Luckily the change that removes assertLint has landed. Sorry for the noise!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.147% when pulling f6efb8d on moar_test_diags into 9443d83 on master.

@@ -214,32 +215,6 @@ abstract class LintRuleTest extends PubPackageResolutionTest {
fail(buffer.toString());
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np

@pq pq merged commit 966da0a into master Sep 30, 2021
@pq pq deleted the moar_test_diags branch September 30, 2021 22:34
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
* cleanup asserts

* test diagnostic cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants