Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super param support for library_private_types_in_public_api #3180

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

pq
Copy link
Member

@pq pq commented Jan 24, 2022

See: #3131

/cc @bwilkerson

@coveralls
Copy link

coveralls commented Jan 24, 2022

Coverage Status

Coverage decreased (-0.003%) to 94.234% when pulling fc0502b on library_private_types_in_public_api_super_params into f4d926d on master.

Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the following case:

class _O extends Object {}
class _A {
  _A(_O o);
}
class B extends _A {
  B(super.o); // lint?
}

My expectation is that this would also be flagged, even though the type of the parameter is implicit rather than explicit, but I don't think the code as written will catch it.

@pq pq merged commit 4782804 into master Feb 14, 2022
@pq pq deleted the library_private_types_in_public_api_super_params branch February 14, 2022 17:27
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
…ang/linter#3180)

* super param support for `library_private_types_in_public_api`

* fix implicit type case

* fix field formal param implicit type checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants