Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ use_super_initializers #3265

Merged
merged 5 commits into from
Mar 7, 2022
Merged

+ use_super_initializers #3265

merged 5 commits into from
Mar 7, 2022

Conversation

pq
Copy link
Member

@pq pq commented Mar 3, 2022

Fixes #3174

/cc @bwilkerson

@coveralls
Copy link

coveralls commented Mar 3, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.67% when pulling 9bfc9d7 on use_super_initializers into 90e8ad5 on master.

@pq
Copy link
Member Author

pq commented Mar 3, 2022 •
edited
Loading

We'll want to do some runs on big code bases to sanity check but at a quick glance these results from running over analyzer look pretty good:

☁  linter [use_super_initializers] dart bin/linter.dart --rules=use_super_initializers ../dart/sdk/pkg/analyzer
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/generated/parser_test_base.dart 759:42 [lint] Convert 'source' and 'errorListener' to super parameters.
  ParserProxy._(Token firstToken, Source source, this.errorListener,
                                         ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/generated/parser_test_base.dart 761:13 [lint] Convert 'allowNativeClause' to a super parameter.
      {bool allowNativeClause = false,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/generated/parser_test_base.dart 763:25 [lint] Convert 'lineInfo' to a super parameter.
      required LineInfo lineInfo})
                        ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/generated/parser_fasta_listener.dart 33:37 [lint] Convert 'listener' to a super parameter.
  ForwardingTestListener([Listener? listener]) : super(listener);
                                    ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/generated/test_support.dart 522:28 [lint] Convert 'path' and 'content' to super parameters.
  TestSourceWithUri(String path, this.uri, [String content = ''])
                           ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/verify_tests_test.dart 20:23 [lint] Convert 'testDirPath' to a super parameter.
  _VerifyTests(String testDirPath, {List<String>? excludedPaths})
                      ^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/verify_tests_test.dart 20:51 [lint] Convert 'excludedPaths' to a super parameter.
  _VerifyTests(String testDirPath, {List<String>? excludedPaths})
                                                  ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/util/id_testing_helper.dart 232:11 [lint] Convert 'mainUri', 'actualMaps', and 'globalData' to super parameters.
      Uri mainUri,
          ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/reachability_test.dart 70:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri,
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/inheritance_test.dart 79:33 [lint] Convert 'uri' and 'actualMap' to super parameters.
  _InheritanceDataExtractor(Uri uri, Map<Id, ActualData<String>> actualMap)
                                ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/why_not_promoted_test.dart 53:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<String?>> actualMap, this._flowResult)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/constant_test.dart 58:30 [lint] Convert 'uri' and 'actualMap' to super parameters.
  ConstantsDataExtractor(Uri uri, Map<Id, ActualData<String>> actualMap)
                             ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/type_promotion_test.dart 45:35 [lint] Convert 'uri' and 'actualMap' to super parameters.
  _TypePromotionDataExtractor(Uri uri, Map<Id, ActualData<DartType>> actualMap)
                                  ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/definite_assignment_test.dart 65:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<String>> actualMap, this._flowResult)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/nullability_test.dart 67:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<String>> actualMap, this._typeSystem)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/assigned_variables_test.dart 57:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<_Data>> actualMap, this._flowResult)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/inferred_variable_types_test.dart 49:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<DartType>> actualMap)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/definite_unassignment_test.dart 65:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<String>> actualMap, this._flowResult)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/id_tests/inferred_type_arguments_test.dart 50:11 [lint] Convert 'uri' and 'actualMap' to super parameters.
      Uri uri, Map<Id, ActualData<List<DartType>>> actualMap)
          ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/test/src/lint/lint_rule_test.dart 73:44 [lint] Convert 'listener' and 'source' to super parameters.
  CollectingReporter(AnalysisErrorListener listener, Source source)
                                           ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/file_system/overlay_file_system.dart 122:40 [lint] Convert 'provider' and 'file' to super parameters.
  _OverlayFile(OverlayResourceProvider provider, File file)
                                       ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/file_system/overlay_file_system.dart 236:42 [lint] Convert 'provider' and 'folder' to super parameters.
  _OverlayFolder(OverlayResourceProvider provider, Folder folder)
                                         ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/file_system/memory_file_system.dart 340:38 [lint] Convert 'provider' and 'path' to super parameters.
  _MemoryFile(MemoryResourceProvider provider, String path)
                                     ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/file_system/memory_file_system.dart 437:40 [lint] Convert 'provider' and 'path' to super parameters.
  _MemoryFolder(MemoryResourceProvider provider, String path)
                                       ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/file_system/physical_file_system.dart 97:25 [lint] Convert 'file' to a super parameter.
  _PhysicalFile(io.File file) : super(file);
                        ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/file_system/physical_file_system.dart 209:32 [lint] Convert 'directory' to a super parameter.
  _PhysicalFolder(io.Directory directory) : super(directory);
                               ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/exception/exception.dart 99:26 [lint] Convert 'message', 'exception', and 'stackTrace' to super parameters.
  SilentException(String message, Object exception, StackTrace stackTrace)
                         ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/lint/linter.dart 877:22 [lint] Convert 'name' and 'message' to super parameters.
  _LintCode._(String name, String message) : super(name, message);
                     ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 48:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 49:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 50:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 107:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 108:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 109:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 279:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 280:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart 281:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/util/performance/operation_performance.dart 59:43 [lint] Convert 'name' to a super parameter.
  OperationPerformanceDataImpl_int(String name) : super(name);
                                          ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/file_content_cache.dart 67:47 [lint] Convert 'resourceProvider' to a super parameter.
  _FileContentCacheEphemeral(ResourceProvider resourceProvider)
                                              ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/file_content_cache.dart 80:42 [lint] Convert 'resourceProvider' to a super parameter.
  _FileContentCacheImpl(ResourceProvider resourceProvider)
                                         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 43:36 [lint] Convert 'session', 'path', 'uri', 'lineInfo', and 'isPart' to super parameters.
  ErrorsResultImpl(AnalysisSession session, String path, Uri uri,
                                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 62:23 [lint] Convert 'session' to a super parameter.
      AnalysisSession session, this.path, this.uri, this.lineInfo, this.isPart)
                      ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 78:43 [lint] Convert 'session' to a super parameter.
  ParsedLibraryResultImpl(AnalysisSession session, this.units) : super(session);
                                          ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 121:40 [lint] Convert 'session', 'path', 'uri', 'lineInfo', and 'isPart' to super parameters.
  ParsedUnitResultImpl(AnalysisSession session, String path, Uri uri,
                                       ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 192:45 [lint] Convert 'session' to a super parameter.
  ResolvedLibraryResultImpl(AnalysisSession session, this.element, this.units)
                                            ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 244:23 [lint] Convert 'session', 'path', 'uri', 'lineInfo', and 'isPart' to super parameters.
      AnalysisSession session,
                      ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/results.dart 272:41 [lint] Convert 'session', 'path', 'uri', 'lineInfo', and 'isPart' to super parameters.
  UnitElementResultImpl(AnalysisSession session, String path, Uri uri,
                                        ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/experiments_impl.dart 278:24 [lint] Convert 'stringIndex' to a super parameter.
  ConflictingFlags(int stringIndex, this.previousStringIndex, this.feature,
                       ^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/experiments_impl.dart 384:31 [lint] Convert 'flagIndex' to a super parameter.
  IllegalUseOfExpiredFlag(int flagIndex, this.feature) : super._(flagIndex);
                              ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/experiments_impl.dart 408:35 [lint] Convert 'flagIndex' to a super parameter.
  UnnecessaryUseOfExpiredFlag(int flagIndex, this.feature) : super._(flagIndex);
                                  ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/analysis/experiments_impl.dart 426:24 [lint] Convert 'flagIndex' to a super parameter.
  UnrecognizedFlag(int flagIndex, this.flag) : super._(flagIndex);
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/type.dart 89:35 [lint] Convert 'alias' to a super parameter.
    InstantiatedTypeAliasElement? alias,
                                  ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/type.dart 449:27 [lint] Convert 'element' to a super parameter.
    required ClassElement element,
                          ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/type.dart 452:35 [lint] Convert 'alias' to a super parameter.
    InstantiatedTypeAliasElement? alias,
                                  ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/type.dart 1118:35 [lint] Convert 'element' to a super parameter.
    required TypeParameterElement element,
                                  ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/type.dart 1121:35 [lint] Convert 'alias' to a super parameter.
    InstantiatedTypeAliasElement? alias,
                                  ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 81:35 [lint] Convert 'name' and 'offset' to super parameters.
  AbstractClassElementImpl(String name, int offset) : super(name, offset);
                                  ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 531:27 [lint] Convert 'name' and 'offset' to super parameters.
  ClassElementImpl(String name, int offset) : super(name, offset);
                          ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1248:32 [lint] Convert 'name' and 'offset' to super parameters.
  ConstFieldElementImpl(String name, int offset) : super(name, offset);
                               ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1263:40 [lint] Convert 'name' and 'offset' to super parameters.
  ConstLocalVariableElementImpl(String name, int offset) : super(name, offset);
                                       ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1301:33 [lint] Convert 'name' and 'offset' to super parameters.
  ConstructorElementImpl(String name, int offset) : super(name, offset);
                                ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1481:43 [lint] Convert 'name' and 'offset' to super parameters.
  ConstTopLevelVariableElementImpl(String name, int offset)
                                          ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1548:21 [lint] Convert 'name' to a super parameter.
    required String name,
                    ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1549:18 [lint] Convert 'nameOffset' to a super parameter.
    required int nameOffset,
                 ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1550:28 [lint] Convert 'parameterKind' to a super parameter.
    required ParameterKind parameterKind,
                           ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1569:22 [lint] Convert 'name' to a super parameter.
    required String? name,
                     ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1570:18 [lint] Convert 'nameOffset' to a super parameter.
    required int nameOffset,
                 ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1571:28 [lint] Convert 'parameterKind' to a super parameter.
    required ParameterKind parameterKind,
                           ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1589:21 [lint] Convert 'name' to a super parameter.
    required String name,
                    ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1590:18 [lint] Convert 'nameOffset' to a super parameter.
    required int nameOffset,
                 ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 1591:28 [lint] Convert 'parameterKind' to a super parameter.
    required ParameterKind parameterKind,
                           ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 2684:26 [lint] Convert 'name' and 'offset' to super parameters.
  EnumElementImpl(String name, int offset) : super(name, offset);
                         ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 2820:32 [lint] Convert 'name' and 'offset' to super parameters.
  ExecutableElementImpl(String name, int offset, {Reference? reference})
                               ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 2820:62 [lint] Convert 'reference' to a super parameter.
  ExecutableElementImpl(String name, int offset, {Reference? reference})
                                                             ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3048:32 [lint] Convert 'name' and 'nameOffset' to super parameters.
  ExtensionElementImpl(String? name, int nameOffset) : super(name, nameOffset);
                               ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3220:27 [lint] Convert 'name' and 'offset' to super parameters.
  FieldElementImpl(String name, int offset) : super(name, offset);
                          ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3292:18 [lint] Convert 'nameOffset' to a super parameter.
    required int nameOffset,
                 ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3293:28 [lint] Convert 'parameterKind' to a super parameter.
    required ParameterKind parameterKind,
                           ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3322:30 [lint] Convert 'name' and 'offset' to super parameters.
  FunctionElementImpl(String name, int offset) : super(name, offset);
                             ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3579:27 [lint] Convert 'name' and 'nameOffset' to super parameters.
  LabelElementImpl(String name, int nameOffset, this._onSwitchStatement,
                          ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 3676:57 [lint] Convert 'name' and 'offset' to super parameters.
  LibraryElementImpl(this.context, this.session, String name, int offset,
                                                        ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4129:35 [lint] Convert 'name' and 'offset' to super parameters.
  LocalVariableElementImpl(String name, int offset) : super(name, offset);
                                  ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4167:28 [lint] Convert 'name' and 'offset' to super parameters.
  MethodElementImpl(String name, int offset) : super(name, offset);
                           ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4238:27 [lint] Convert 'name' and 'offset' to super parameters.
  MixinElementImpl(String name, int offset) : super(name, offset);
                          ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4651:42 [lint] Convert 'name' and 'offset' to super parameters.
  NonParameterVariableElementImpl(String name, int offset)
                                         ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4695:22 [lint] Convert 'name' and 'nameOffset' to super parameters.
    required String? name,
                     ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4920:28 [lint] Convert 'name' and 'nameOffset' to super parameters.
  PrefixElementImpl(String name, int nameOffset, {Reference? reference})
                           ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4920:62 [lint] Convert 'reference' to a super parameter.
  PrefixElementImpl(String name, int nameOffset, {Reference? reference})
                                                             ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4964:38 [lint] Convert 'name' and 'offset' to super parameters.
  PropertyAccessorElementImpl(String name, int offset) : super(name, offset);
                                     ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 4969:19 [lint] Convert 'reference' to a super parameter.
      {Reference? reference})
                  ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5068:35 [lint] Convert 'property' to a super parameter.
      PropertyInducingElementImpl property,
                                  ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5069:19 [lint] Convert 'reference' to a super parameter.
      {Reference? reference})
                  ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5130:35 [lint] Convert 'property' to a super parameter.
      PropertyInducingElementImpl property,
                                  ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5131:19 [lint] Convert 'reference' to a super parameter.
      {Reference? reference})
                  ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5216:38 [lint] Convert 'name' and 'offset' to super parameters.
  PropertyInducingElementImpl(String name, int offset) : super(name, offset);
                                     ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5365:18 [lint] Convert 'nameOffset' to a super parameter.
    required int nameOffset,
                 ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5366:28 [lint] Convert 'parameterKind' to a super parameter.
    required ParameterKind parameterKind,
                           ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5423:38 [lint] Convert 'name' and 'offset' to super parameters.
  TopLevelVariableElementImpl(String name, int offset) : super(name, offset);
                                     ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5467:31 [lint] Convert 'name' and 'nameOffset' to super parameters.
  TypeAliasElementImpl(String name, int nameOffset) : super(name, nameOffset);
                              ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5669:35 [lint] Convert 'name' and 'offset' to super parameters.
  TypeParameterElementImpl(String name, int offset) : super(name, offset);
                                  ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5782:36 [lint] Convert 'name' and 'offset' to super parameters.
  UriReferencedElementImpl(String? name, int offset) : super(name, offset);
                                   ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5823:31 [lint] Convert 'name' and 'offset' to super parameters.
  VariableElementImpl(String? name, int offset) : super(name, offset);
                              ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5933:32 [lint] Convert 'name' and 'offset' to super parameters.
  _ExistingElementImpl(String? name, int offset, {Reference? reference})
                               ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/element.dart 5933:62 [lint] Convert 'reference' to a super parameter.
  _ExistingElementImpl(String? name, int offset, {Reference? reference})
                                                             ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/generic_inferrer.dart 662:18 [lint] Convert 'upper' to a super parameter.
      {DartType? upper, DartType? lower})
                 ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/generic_inferrer.dart 662:35 [lint] Convert 'lower' to a super parameter.
      {DartType? upper, DartType? lower})
                                  ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/generic_inferrer.dart 699:41 [lint] Convert 'isNonNullableByDefault' to a super parameter.
      {this.genericClass, required bool isNonNullableByDefault})
                                        ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/generic_inferrer.dart 746:22 [lint] Convert 'isNonNullableByDefault' to a super parameter.
      {required bool isNonNullableByDefault})
                     ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/generic_inferrer.dart 765:22 [lint] Convert 'isNonNullableByDefault' to a super parameter.
      {required bool isNonNullableByDefault})
                     ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/generic_inferrer.dart 783:22 [lint] Convert 'isNonNullableByDefault' to a super parameter.
      {required bool isNonNullableByDefault})
                     ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/type_algebra.dart 252:52 [lint] Convert 'outer' to a super parameter.
  _FreshTypeParametersSubstitutor(_TypeSubstitutor outer) : super(outer);
                                                   ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/inheritance_manager3.dart 19:19 [lint] Convert 'name' to a super parameter.
    required Name name,
                  ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/inheritance_manager3.dart 38:19 [lint] Convert 'name' to a super parameter.
    required Name name,
                  ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 141:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', and 'isLegacy' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 279:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', 'isLegacy', and 'typeParameters' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 319:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', and 'isLegacy' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 735:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', 'isLegacy', and 'typeParameters' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 816:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', and 'isLegacy' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 909:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', 'isLegacy', and 'typeParameters' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 1001:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', and 'isLegacy' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/member.dart 1057:22 [lint] Convert 'typeProvider', 'declaration', 'substitution', and 'isLegacy' to super parameters.
    TypeProviderImpl typeProvider,
                     ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/scope.dart 12:20 [lint] Convert 'parent' to a super parameter.
  ClassScope(Scope parent, ClassElement element) : super(parent) {
                   ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/scope.dart 20:37 [lint] Convert 'parent' to a super parameter.
  ConstructorInitializerScope(Scope parent, ConstructorElement element)
                                    ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/scope.dart 72:11 [lint] Convert 'parent' to a super parameter.
    Scope parent,
          ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/scope.dart 82:11 [lint] Convert 'parent' to a super parameter.
    Scope parent,
          ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/scope.dart 126:20 [lint] Convert 'parent' to a super parameter.
  LocalScope(Scope parent) : super(parent);
                   ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/element/scope.dart 237:11 [lint] Convert 'parent' to a super parameter.
    Scope parent,
          ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 1532:20 [lint] Convert 'comment', 'metadata', 'name', 'typeParameters', 'implementsClause', 'leftBracket', 'members', and 'rightBracket' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 1640:32 [lint] Convert 'comment' and 'metadata' to super parameters.
  ClassMemberImpl(CommentImpl? comment, List<Annotation>? metadata)
                               ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 1666:20 [lint] Convert 'comment', 'metadata', and 'name' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 1785:20 [lint] Convert 'comment', 'metadata', 'keyword', 'name', and 'semicolon' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 2250:42 [lint] Convert 'comment' and 'metadata' to super parameters.
  CompilationUnitMemberImpl(CommentImpl? comment, List<Annotation>? metadata)
                                         ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 2545:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 2960:32 [lint] Convert 'comment' and 'metadata' to super parameters.
  DeclarationImpl(CommentImpl? comment, List<Annotation>? metadata)
                               ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 2986:39 [lint] Convert 'comment' and 'metadata' to super parameters.
  DeclaredIdentifierImpl(CommentImpl? comment, List<Annotation>? metadata,
                                      ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 3053:34 [lint] Convert 'token' to a super parameter.
  DeclaredSimpleIdentifier(Token token) : super(token);
                                 ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 3173:30 [lint] Convert 'comment' and 'metadata' to super parameters.
  DirectiveImpl(CommentImpl? comment, List<Annotation>? metadata)
                             ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 3484:27 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
    required CommentImpl? documentationComment,
                          ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 3573:20 [lint] Convert 'comment', 'metadata', and 'name' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 3679:20 [lint] Convert 'comment', 'metadata', 'keyword', 'libraryUri', 'configurations', 'combinators', and 'semicolon' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4063:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4292:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4388:20 [lint] Convert 'comment', 'metadata', 'covariantKeyword', 'requiredKeyword', and 'identifier' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4529:33 [lint] Convert 'inKeyword' and 'iterator' to super parameters.
      this._loopVariable, Token inKeyword, ExpressionImpl iterator)
                                ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4568:31 [lint] Convert 'inKeyword' and 'iterator' to super parameters.
      this._identifier, Token inKeyword, ExpressionImpl iterator)
                              ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4905:13 [lint] Convert 'leftSeparator', 'condition', 'rightSeparator', and 'updaters' to super parameters.
      Token leftSeparator,
            ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 4952:13 [lint] Convert 'leftSeparator', 'condition', 'rightSeparator', and 'updaters' to super parameters.
      Token leftSeparator,
            ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 5144:20 [lint] Convert 'comment', 'metadata', and 'name' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 5368:29 [lint] Convert 'typeArguments' and 'argumentList' to super parameters.
      TypeArgumentListImpl? typeArguments, ArgumentListImpl argumentList)
                            ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 5503:20 [lint] Convert 'comment', 'metadata', 'keyword', 'name', and 'semicolon' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 5590:20 [lint] Convert 'comment', 'metadata', 'covariantKeyword', 'requiredKeyword', and 'identifier' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 5810:20 [lint] Convert 'comment', 'metadata', 'typedefToken', 'name', and 'semicolon' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 5929:28 [lint] Convert 'keyword' to a super parameter.
  HideCombinatorImpl(Token keyword, List<SimpleIdentifier> hiddenNames)
                           ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 6298:20 [lint] Convert 'comment', 'metadata', 'keyword', 'libraryUri', 'configurations', 'combinators', and 'semicolon' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7110:37 [lint] Convert 'comment' and 'metadata' to super parameters.
  LibraryDirectiveImpl(CommentImpl? comment, List<Annotation>? metadata,
                                    ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7229:26 [lint] Convert 'constKeyword' and 'typeArguments' to super parameters.
  ListLiteralImpl(Token? constKeyword, TypeArgumentListImpl? typeArguments,
                         ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7241:14 [lint] Convert 'constKeyword' and 'typeArguments' to super parameters.
      Token? constKeyword,
             ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7443:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7593:29 [lint] Convert 'typeArguments' and 'argumentList' to super parameters.
      TypeArgumentListImpl? typeArguments, ArgumentListImpl argumentList)
                            ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7740:20 [lint] Convert 'comment', 'metadata', 'name', 'typeParameters', 'implementsClause', 'leftBracket', 'members', and 'rightBracket' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 7815:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment, List<Annotation>? metadata, this._name)
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 8007:20 [lint] Convert 'comment', 'metadata', and 'libraryUri' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 8560:34 [lint] Convert 'comment', 'metadata', and 'partUri' to super parameters.
  PartDirectiveImpl(CommentImpl? comment, List<Annotation>? metadata,
                                 ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 8615:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 9271:30 [lint] Convert 'constKeyword' and 'typeArguments' to super parameters.
  SetOrMapLiteralImpl(Token? constKeyword, TypeArgumentListImpl? typeArguments,
                             ^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 9390:28 [lint] Convert 'keyword' to a super parameter.
  ShowCombinatorImpl(Token keyword, List<SimpleIdentifier> shownNames)
                           ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 9482:20 [lint] Convert 'comment', 'metadata', 'covariantKeyword', 'requiredKeyword', and 'identifier' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 10295:20 [lint] Convert 'comment', 'metadata', 'covariantKeyword', 'requiredKeyword', and 'identifier' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 10400:30 [lint] Convert 'labels', 'keyword', 'colon', and 'statements' to super parameters.
  SwitchCaseImpl(List<Label> labels, Token keyword, this._expression,
                             ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 10439:33 [lint] Convert 'labels', 'keyword', 'colon', and 'statements' to super parameters.
  SwitchDefaultImpl(List<Label> labels, Token keyword, Token colon,
                                ^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 10749:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 10900:30 [lint] Convert 'comment', 'metadata', and 'name' to super parameters.
  TypeAliasImpl(CommentImpl? comment, List<Annotation>? metadata,
                             ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 11091:34 [lint] Convert 'comment' and 'metadata' to super parameters.
  TypeParameterImpl(CommentImpl? comment, List<Annotation>? metadata,
                                 ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 11211:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment, List<Annotation>? metadata, this._uri)
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/ast/ast.dart 11428:20 [lint] Convert 'comment' and 'metadata' to super parameters.
      CommentImpl? comment,
                   ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/hint_codes.g.dart 4519:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/hint_codes.g.dart 4520:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/hint_codes.g.dart 4521:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/ffi_code.g.dart 1816:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/ffi_code.g.dart 1817:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/ffi_code.g.dart 1818:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart 1735:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart 1736:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart 1737:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/lint_codes.dart 16:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/lint_codes.dart 47:33 [lint] Convert 'name' and 'problemMessage' to super parameters.
  const SecurityLintCode(String name, String problemMessage,
                                ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/error/lint_codes.dart 48:36 [lint] Convert 'correctionMessage' to a super parameter.
      {String? uniqueName, String? correctionMessage})
                                   ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/resolver/applicable_extensions.dart 77:56 [lint] Convert 'extension' to a super parameter.
  _NotInstantiatedExtensionWithMember(ExtensionElement extension,
                                                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dart/resolver/applicable_extensions.dart 94:59 [lint] Convert 'extension' to a super parameter.
  _NotInstantiatedExtensionWithoutMember(ExtensionElement extension)
                                                          ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/validators/dependency_validator.dart 16:40 [lint] Convert 'provider' and 'source' to super parameters.
  DependencyValidator(ResourceProvider provider, Source source)
                                       ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/validators/name_validator.dart 13:34 [lint] Convert 'provider' and 'source' to super parameters.
  NameValidator(ResourceProvider provider, Source source)
                                 ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/validators/flutter_validator.dart 15:37 [lint] Convert 'provider' and 'source' to super parameters.
  FlutterValidator(ResourceProvider provider, Source source)
                                    ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/validators/field_validator.dart 20:35 [lint] Convert 'provider' and 'source' to super parameters.
  FieldValidator(ResourceProvider provider, Source source)
                                  ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart 577:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart 578:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart 579:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/workspace/pub.dart 32:22 [lint] Convert 'provider', 'packageMap', and 'root' to super parameters.
    ResourceProvider provider,
                     ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/workspace/basic.dart 21:22 [lint] Convert 'provider', 'packageMap', and 'root' to super parameters.
    ResourceProvider provider,
                     ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart 115:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart 116:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart 117:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/dartdoc/dartdoc_directive_info.dart 200:45 [lint] Convert 'full' to a super parameter.
  DocumentationWithSummary({required String full, required this.summary})
                                            ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 16877:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 16878:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 16879:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 16982:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 16983:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 16984:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 17325:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 17326:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/codes.g.dart 17327:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/analyzer_error_code.dart 11:13 [lint] Convert 'correctionMessage' to a super parameter.
    String? correctionMessage,
            ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/analyzer_error_code.dart 12:10 [lint] Convert 'hasPublishedDocs' to a super parameter.
    bool hasPublishedDocs = false,
         ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/analyzer_error_code.dart 13:10 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
    bool isUnresolvedIdentifier = false,
         ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/analyzer_error_code.dart 14:21 [lint] Convert 'name' to a super parameter.
    required String name,
                    ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/analyzer_error_code.dart 15:21 [lint] Convert 'problemMessage' to a super parameter.
    required String problemMessage,
                    ^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/error/analyzer_error_code.dart 16:21 [lint] Convert 'uniqueName' to a super parameter.
    required String uniqueName,
                    ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/exception/exception.dart 14:12 [lint] Convert 'exception' and 'stackTrace' to super parameters.
    Object exception,
           ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary/package_bundle_reader.dart 70:23 [lint] Convert 'uri' to a super parameter.
  InSummarySource(Uri uri, this.summaryPath) : super(uri);
                      ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary/flat_buffers.dart 722:32 [lint] Convert 'bc' and 'offset' to super parameters.
  _FbFloat64List(BufferContext bc, int offset) : super(bc, offset);
                               ^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary/flat_buffers.dart 736:52 [lint] Convert 'bp' and 'offset' to super parameters.
  _FbGenericList(this.elementReader, BufferContext bp, int offset)
                                                   ^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary/flat_buffers.dart 774:31 [lint] Convert 'bc' and 'offset' to super parameters.
  _FbUint32List(BufferContext bc, int offset) : super(bc, offset);
                              ^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary/flat_buffers.dart 784:30 [lint] Convert 'bc' and 'offset' to super parameters.
  _FbUint8List(BufferContext bc, int offset) : super(bc, offset);
                             ^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/package_bundle_reader.dart 10:38 [lint] Convert 'bytes' to a super parameter.
  PackageBundle.fromBuffer(Uint8List bytes) : super(bytes);
                                     ^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 88:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 129:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 149:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 267:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 291:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 312:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 340:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 362:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 1239:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 1262:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 1285:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 1746:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_reader.dart 1774:24 [lint] Convert 'reference', 'libraryReader', 'unitElement', and 'offset' to super parameters.
    required Reference reference,
                       ^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_writer.dart 505:23 [lint] Convert 'sink' to a super parameter.
    required ByteSink sink,
                      ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_writer.dart 506:28 [lint] Convert 'stringIndexer' to a super parameter.
    required StringIndexer stringIndexer,
                           ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/lib/src/summary2/bundle_writer.dart 953:23 [lint] Convert 'sink' to a super parameter.
    required ByteSink sink,
                      ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 239:16 [lint] Convert 'comment' to a super parameter.
      {String? comment,
               ^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 240:15 [lint] Convert 'correctionMessage' to a super parameter.
      String? correctionMessage,
              ^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 241:15 [lint] Convert 'documentation' to a super parameter.
      String? documentation,
              ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 242:12 [lint] Convert 'hasPublishedDocs' to a super parameter.
      bool hasPublishedDocs = false,
           ^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 243:12 [lint] Convert 'isUnresolvedIdentifier' to a super parameter.
      bool isUnresolvedIdentifier = false,
           ^^^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 244:23 [lint] Convert 'problemMessage' to a super parameter.
      required String problemMessage,
                      ^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 245:15 [lint] Convert 'sharedName' to a super parameter.
      String? sharedName})
              ^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 255:56 [lint] Convert 'yaml' to a super parameter.
  AnalyzerErrorCodeInfo.fromYaml(Map<Object?, Object?> yaml)
                                                       ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/messages/error_code_info.dart 545:56 [lint] Convert 'yaml' to a super parameter.
  FrontEndErrorCodeInfo.fromYaml(Map<Object?, Object?> yaml)
                                                       ^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 47:29 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
  ClassDeclaration(Comment? documentationComment, List<Annotation>? metadata,
                            ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 54:24 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
  ClassMember(Comment? documentationComment, List<Annotation>? metadata)
                       ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 90:16 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
      Comment? documentationComment, List<Annotation>? metadata)
               ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 99:16 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
      Comment? documentationComment, List<Annotation>? metadata, this.name)
               ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 109:16 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
      Comment? documentationComment, List<Annotation>? metadata, this.name)
               ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 119:28 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
  EnumDeclaration(Comment? documentationComment, List<Annotation>? metadata,
                           ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 160:30 [lint] Convert 'documentationComment' and 'metadata' to super parameters.
  MethodDeclaration(Comment? documentationComment, List<Annotation>? metadata,
                             ^^^^^^^^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/mini_ast.dart 669:32 [lint] Convert 'listener' to a super parameter.
  MiniAstParser(MiniAstBuilder listener) : super(listener);
                               ^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/generate.dart 186:35 [lint] Convert 'idl' and 'outBuffer' to super parameters.
  _BuilderGenerator(idl_model.Idl idl, StringBuffer outBuffer, this.cls)
                                  ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/generate.dart 810:38 [lint] Convert 'idl' and 'outBuffer' to super parameters.
  _EnumReaderGenerator(idl_model.Idl idl, StringBuffer outBuffer, this.enum_)
                                     ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/generate.dart 838:44 [lint] Convert 'idl' and 'outBuffer' to super parameters.
  _FlatBufferSchemaGenerator(idl_model.Idl idl, StringBuffer outBuffer)
                                           ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/generate.dart 931:32 [lint] Convert 'idl' and 'outBuffer' to super parameters.
  _ImplGenerator(idl_model.Idl idl, StringBuffer outBuffer, this.cls)
                               ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/generate.dart 1039:33 [lint] Convert 'idl' and 'outBuffer' to super parameters.
  _MixinGenerator(idl_model.Idl idl, StringBuffer outBuffer, this.cls)
                                ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/generate.dart 1129:34 [lint] Convert 'idl' and 'outBuffer' to super parameters.
  _ReaderGenerator(idl_model.Idl idl, StringBuffer outBuffer, this.cls)
                                 ^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/idl_model.dart 25:22 [lint] Convert 'documentation' and 'name' to super parameters.
    required String? documentation,
                     ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/idl_model.dart 53:27 [lint] Convert 'documentation' and 'name' to super parameters.
  EnumDeclaration(String? documentation, String name)
                          ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/idl_model.dart 59:32 [lint] Convert 'documentation' and 'name' to super parameters.
  EnumValueDeclaration(String? documentation, String name)
                               ^^^^^^^^^^^^^
/Users/pq/src/repos/dart/sdk/pkg/analyzer/tool/summary/idl_model.dart 78:22 [lint] Convert 'documentation' and 'name' to super parameters.
    required String? documentation,
                     ^^^^^^^^^^^^^

1327 files analyzed, 267 issues found, in 35753 ms.

(EDIT: updated 03/04)

Will be fantastic to get this enabled in dart fix!

bwilkerson
bwilkerson reviewed Mar 3, 2022
View reviewed changes
lib/src/rules/use_super_initializers.dart Outdated Show resolved Hide resolved
lib/src/rules/use_super_initializers.dart Outdated Show resolved Hide resolved
lib/src/rules/use_super_initializers.dart Outdated Show resolved Hide resolved
lib/src/rules/use_super_initializers.dart Outdated Show resolved Hide resolved
test/rules/use_super_initializers_test.dart Outdated Show resolved Hide resolved
@bwilkerson
Copy link
Member

Unfortunately, that output doesn't always provide enough context for me to know whether the lint ought to have fired or not. In the cases where it does, it does appear to be valid.

bwilkerson
bwilkerson approved these changes Mar 4, 2022
View reviewed changes
lib/src/rules/use_super_initializers.dart Outdated Show resolved Hide resolved
test/rules/use_super_initializers_test.dart Outdated Show resolved Hide resolved
lib/src/rules/use_super_initializers.dart Outdated Show resolved Hide resolved
@pq pq merged commit 4bfb49a into master Mar 7, 2022
@pq pq deleted the use_super_initializers branch March 7, 2022 18:58
mockturtl added a commit to mockturtl/tidy that referenced this pull request Mar 15, 2022
@mockturtl
feat: use_super_parameters
cc4e236 
dart-lang/linter#3265
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
+ use_super_initializers (dart-lang/linter#3265)
dcef116 
* + use_super_initializers

* rename

* support positionals

* quotedAndCommaSeparatedWithAnd

* fixes + tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider a lint to encourage use of super-initializers where possible
3 participants
@pq @coveralls @bwilkerson