This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
remove DartProject references
#3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
bwilkerson
approved these changes
May 13, 2022
| @@ -84,28 +73,33 @@ class _Visitor extends SimpleAstVisitor<void> { | |||
| _Visitor(this.rule); | |||
|
|
|||
| @override | |||
| // ignore: prefer_expression_function_bodies | |||
There was a problem hiding this comment.
It seems wrong to recommend using an expression function body when there's no value to return. Somehow void f() => null; feels wrong.
| @@ -4,4 +4,5 @@ | |||
|
|
|||
| // test w/ `dart test -N package_prefixed_library_names` | |||
|
|
|||
| library linter.not_where_it_should_be; //LINT | |||
| // See: https://github.com/dart-lang/linter/issues/3395 | |||
| library linter.not_where_it_should_be; //FAILING | |||
There was a problem hiding this comment.
Why would commenting out code that isn't being run cause the test to start failing? How confident are we that the commented out code really isn't being run?
There was a problem hiding this comment.
It is being run in the linter tests since they do take the code path that initializes project instances. That's however the only path that does and so the tests here are out of sync w/ how server and the analyzer CLIs work. Obviously, not good!
There was a problem hiding this comment.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dart-lang/sdk#58734
/cc @bwilkerson