Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint implicit_call_tearoffs #3592

Merged
merged 26 commits into from
Oct 27, 2022
Merged

Add lint implicit_call_tearoffs #3592

merged 26 commits into from
Oct 27, 2022

Commits on Aug 10, 2022

  1. Add lint avoid_implicit_call_tearoffs 

    In an effort to simplify the language we may consider removing the
implicit `call` tearoff which can coerce an instance of any class which
defines a `call` method into a `Function` type. Authors should
explicitly add the `.call` so there is less magic.
    @natebosch
    natebosch committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    dce7fbe View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Fix the registration to the correct node type

    @natebosch
    natebosch committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    e8893cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into avoid-implicit-call-tearoffs 

    Bump to new analyzer version in https://dart-review.googlesource.com/c/sdk/+/254465
    @natebosch
    natebosch committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    ef24737 View commit details
    Browse the repository at this point in the history

  3. Use unpublished analyzer

    @natebosch
    natebosch committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    4fe066b View commit details
    Browse the repository at this point in the history

  4. Remove expectations for casting to Function 

    These don't seem to have an ImplicitCallReference
    @natebosch
    natebosch committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    aa544de View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Expand test cases

    @natebosch
    natebosch committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    cdc6e7f View commit details
    Browse the repository at this point in the history

  2. Rename rule without "avoid"

    @natebosch
    natebosch committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    09a716e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    47c8f93 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Report lint for the entire implicit call node

    @natebosch
    natebosch committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ba26a19 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    3fffa04 View commit details
    Browse the repository at this point in the history

  2. Remove dependency override, analyzer is published

    @natebosch
    natebosch committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    401f742 View commit details
    Browse the repository at this point in the history

  3. Match version bump

    @natebosch
    natebosch committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    f685194 View commit details
    Browse the repository at this point in the history

  4. Add to all.yaml

    @natebosch
    natebosch committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    fb8be4d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a096283 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    5734d9f View commit details
    Browse the repository at this point in the history

  2. Move changelog entry

    @natebosch
    natebosch committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    3673cab View commit details
    Browse the repository at this point in the history

  3. Do not change sorting for capital

    @natebosch
    natebosch committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    3197844 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    c6def98 View commit details
    Browse the repository at this point in the history

  2. End description with .

    @natebosch
    natebosch committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4f131f1 View commit details
    Browse the repository at this point in the history

  3. Prune leading newline from description

    @natebosch
    natebosch committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4ef3b92 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Rename to plural

    @natebosch
    natebosch committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    72d306e View commit details
    Browse the repository at this point in the history

  2. Expand description

    @natebosch
    natebosch committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    58f4507 View commit details
    Browse the repository at this point in the history

  3. Add a bunch of test cases with a generic

    @natebosch
    natebosch committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f3ba6c8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8e8876f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Remove unnecessary ellipsis

    @natebosch
    natebosch committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    d18710a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge branch 'main' into avoid-implicit-call-tearoffs

    @natebosch
    natebosch committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e940a65 View commit details
    Browse the repository at this point in the history