remove the 'library_names' lint

[devoncarew]

• remove the 'library_names' lint

We didn't have a specific issue where we discussed this, but it's ~implicit in #181 - adding unnecessary_library_name.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[goderbauer]

What is the idea behind removing this? If you have a necessary library name, shouldn't that one still follow the naming rules enforced by the lint? The upcoming unnecessary_library_name will not ban all library names, right?

[devoncarew]

If you have a necessary library name, shouldn't that one still follow the naming rules enforced by the lint? The upcoming unnecessary_library_name will not ban all library names, right?

Some library directives are necessary (for instance, as a place to hang annotations off of); library names themselves are not. That's why we're considering unnecessary_library_name ("Don't have a library name in a library declaration.").

This does align w/ the effective dart recommendation - "DON'T explicitly name libraries: Appending a name to the library directive is technically possible, but is a legacy feature and discouraged." (https://dart.dev/effective-dart/style#dont-explicitly-name-libraries).

[goderbauer]

LGTM

[goderbauer]

Makes sense. Thanks for the explanation.