Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unnecessary_library_name to recommended #198

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

devoncarew
Copy link
Member


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I imagine this will be a big simplicity and education win for lots of projects :)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@devoncarew devoncarew merged commit 8f93c79 into main Aug 7, 2024
6 checks passed
@devoncarew devoncarew deleted the add_unnecessary_library_name branch August 7, 2024 22:40
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
* add unnecessary_library_name to recommended

* update the workflow config

* link to the lint's docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding unnecessary_library_name to recommended
4 participants