Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pub run syntax and remove 404 images #625

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Update pub run syntax and remove 404 images #625

merged 1 commit into from
Oct 16, 2024

Conversation

andrechalella
Copy link
Contributor

  • Obsolete pub run syntax is used in some files. This was replaced with dart run.
    • pub run test:test was replaced with dart run test
  • There were a couple rotten links for images demonstrating tests running. They were removed.

I think this PR is very minor and doesn't warrant opening an issue, version changes etc.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

srawlins
srawlins approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

benchmark/input.md
@@ -85,14 +85,9 @@ void main() {

## Running Tests

A single test file can be run just using `pub run test:test path/to/test.dart`
(on Dart 1.10, this can be shortened to `pub run test path/to/test.dart`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. What a wildly old comment!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11355523513

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.099%
Totals Coverage Status
Change from base Build 11117829749: 0.0%
Covered Lines: 1552
Relevant Lines: 1615
💛 - Coveralls

@srawlins srawlins merged commit 207bb44 into dart-lang:master Oct 16, 2024
8 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 28, 2024
@devoncarew
[deps] rev async, clock, collection, convert, core, crypto, dartdoc, …
83b0a89 
…ecosystem, fixnum, http, lints, logging, markdown, path, sync_http, test, typed_data, vector_math, web

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/5f70a99..d6a6a4d):
  d6a6a4d  2024-10-17  Moritz  Update README.md before archiving (dart-archive/async#287)

clock (https://github.com/dart-lang/clock/compare/7956d60..8dfee80):
  8dfee80  2024-10-28  Moritz  Update README.md (dart-archive/clock#70)

collection (https://github.com/dart-lang/collection/compare/887b826..96afcc2):
  96afcc2  2024-10-21  Moritz  Update README.md before archiving (dart-archive/collection#362)

convert (https://github.com/dart-lang/convert/compare/d361833..836082a):
  836082a  2024-10-17  Moritz  Update README.md before archiving (dart-archive/convert#110)

core (https://github.com/dart-lang/core/compare/2a436d5..9ad6888):
  9ad68884  2024-10-25  Kevin Moore  os_detect: bump lints and SDK versions (dart-lang/core#713)

crypto (https://github.com/dart-lang/crypto/compare/3d26ef4..255edfb):
  255edfb  2024-10-17  Moritz  Update README.md before archiving (dart-archive/crypto#184)

dartdoc (https://github.com/dart-lang/dartdoc/compare/73344a2..5168f81):
  5168f81a  2024-10-27  Parker Lougheed  Remove unnecessary and unused styles (dart-lang/dartdoc#3918)
  d4876f94  2024-10-25  Parker Lougheed  Compress generated css by configuring sass output style (dart-lang/dartdoc#3919)
  d83146fa  2024-10-25  Parker Lougheed  Generate included css using sass (dart-lang/dartdoc#3917)
  4d461298  2024-10-24  Parker Lougheed  Update to Dart 3.5 and web 1.1 (dart-lang/dartdoc#3915)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2d58550..66ddc4f):
  66ddc4f  2024-10-28  Devon Carew  refactor the CI to use per-package workflow config files (dart-lang/ecosystem#312)
  673428a  2024-10-24  Devon Carew  ignore redundant 'type-' labels (dart-lang/ecosystem#309)
  d5c8c18  2024-10-15  Devon Carew  remove the 'version' section from the health checks (dart-lang/ecosystem#305)

fixnum (https://github.com/dart-lang/fixnum/compare/83293b8..8543972):
  8543972  2024-10-17  Moritz  Update README.md before archiving (dart-archive/fixnum#134)

http (https://github.com/dart-lang/http/compare/5e2281e..f5ec11c):
  f5ec11c  2024-10-25  dependabot[bot]  Bump the github-actions group across 1 directory with 5 updates (dart-lang/http#1392)
  bd8eb4b  2024-10-24  Brian Quinlan  Remove package:java_http (dart-lang/http#1389)
  d921e48  2024-10-23  Brian Quinlan  Replace Objective-C implemented delegates with Dart implementations (dart-lang/http#1218)

lints (https://github.com/dart-lang/lints/compare/5016d63..19d99bc):
  19d99bc  2024-10-21  Moritz  Update README.md before archiving (dart-lang/lints#214)

logging (https://github.com/dart-lang/logging/compare/6fa0560..a41a508):
  a41a508  2024-10-18  Moritz  Update README.md (dart-archive/logging#175)

markdown (https://github.com/dart-lang/markdown/compare/d53feae..207bb44):
  207bb44  2024-10-16  andrechalella  Update pub run syntax and remove 404 images (dart-lang/markdown#625)
  62153ee  2024-10-16  andrechalella  Fix `RangeError` hazards in links (dart-lang/markdown#624)

path (https://github.com/dart-lang/path/compare/e969f42..7e3d5d8):
  7e3d5d8  2024-10-17  Moritz  Update README.md (dart-archive/path#172)

sync_http (https://github.com/dart-lang/sync_http/compare/91c0dd5..44b5913):
  44b5913  2024-10-28  Devon Carew  Update analysis_options.yaml (google/sync_http.dart#51)
  df54f0d  2024-10-28  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 (google/sync_http.dart#50)

test (https://github.com/dart-lang/test/compare/73e30fb..fe38650):
  fe386504  2024-10-22  Nate Bosch  Remove deprecated lint package_api_docs (dart-lang/test#2411)

typed_data (https://github.com/dart-lang/typed_data/compare/6abfafd..b269d39):
  b269d39  2024-10-18  Moritz  Update README.md before archiving (dart-archive/typed_data#94)

vector_math (https://github.com/google/vector_math.dart/compare/2cfbe2c..da9889f):
  da9889f  2024-10-16  dependabot[bot]  Bump the github-actions group across 1 directory with 2 updates (google/vector_math.dart#332)
  33d5ecb  2024-10-15  Devon Carew  Update dependabot.yaml (google/vector_math.dart#331)

web (https://github.com/dart-lang/web/compare/8478cd2..d3a61aa):
  d3a61aa  2024-10-12  Parker Lougheed  Remove deprecated package_api_docs lint (dart-lang/web#315)

Change-Id: I465d31409f68a0d6f10a60ffb9cfd505957f79e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
@andrechalella
Update pub run syntax and remove 404 images (dart-lang/markdown#625)
6882f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrechalella @coveralls @srawlins