Skip to content

Commit

Permalink
Correctly escape comments that may contain tags (#1426)
Browse files Browse the repository at this point in the history
  • Loading branch information
brianquinlan authored Aug 14, 2024
1 parent 306fcd2 commit 4eaec5a
Show file tree
Hide file tree
Showing 15 changed files with 839 additions and 835 deletions.
4 changes: 4 additions & 0 deletions pkgs/jnigen/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.1

- Add backticks to code references in doc comments.

## 0.10.0

- Added support for Kotlin's top-level functions and fields.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/jnigen/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class AndroidUtils extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>, ffi.Pointer<ffi.Void>, int)>();
/// from: static public void showToast(android.app.Activity mainActivity, java.lang.CharSequence text, int duration)
/// from: `static public void showToast(android.app.Activity mainActivity, java.lang.CharSequence text, int duration)`
static void showToast(
jni.JObject mainActivity,
jni.JObject text,
Expand Down
424 changes: 212 additions & 212 deletions pkgs/jnigen/example/in_app_java/lib/android_utils.dart

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions pkgs/jnigen/example/kotlin_plugin/lib/kotlin_bindings.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import 'dart:isolate' show ReceivePort;
import 'package:jni/internal_helpers_for_jnigen.dart';
import 'package:jni/jni.dart' as jni;

/// from: Example
/// from: `Example`
class Example extends jni.JObject {
@override
late final jni.JObjType<Example> $type = type;
Expand Down Expand Up @@ -57,7 +57,7 @@ class Example extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public void <init>()
/// from: `public void <init>()`
/// The returned object must be released after use, by calling the [release] method.
factory Example() {
return Example.fromReference(
Expand All @@ -81,7 +81,7 @@ class Example extends jni.JObject {
jni.JniResult Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public final java.lang.Object thinkBeforeAnswering(kotlin.coroutines.Continuation continuation)
/// from: `public final java.lang.Object thinkBeforeAnswering(kotlin.coroutines.Continuation continuation)`
/// The returned object must be released after use, by calling the [release] method.
Future<jni.JString> thinkBeforeAnswering() async {
final $p = ReceivePort();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import 'dart:isolate' show ReceivePort;
import 'package:jni/internal_helpers_for_jnigen.dart';
import 'package:jni/jni.dart' as jni;

/// from: com.example.notification_plugin.Notifications
/// from: `com.example.notification_plugin.Notifications`
class Notifications extends jni.JObject {
@override
late final jni.JObjType<Notifications> $type = type;
Expand Down Expand Up @@ -62,7 +62,7 @@ class Notifications extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public void <init>()
/// from: `public void <init>()`
/// The returned object must be released after use, by calling the [release] method.
factory Notifications() {
return Notifications.fromReference(
Expand Down Expand Up @@ -96,7 +96,7 @@ class Notifications extends jni.JObject {
ffi.Pointer<ffi.Void>,
ffi.Pointer<ffi.Void>)>();

/// from: static public void showNotification(android.content.Context context, int notificationID, java.lang.String title, java.lang.String text)
/// from: `static public void showNotification(android.content.Context context, int notificationID, java.lang.String title, java.lang.String text)`
static void showNotification(
jni.JObject context,
int notificationID,
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import 'dart:isolate' show ReceivePort;
import 'package:jni/internal_helpers_for_jnigen.dart';
import 'package:jni/jni.dart' as jni;

/// from: org.apache.pdfbox.pdmodel.PDDocumentInformation
/// from: `org.apache.pdfbox.pdmodel.PDDocumentInformation`
///
/// This is the document metadata. Each getXXX method will return the entry if
/// it exists or null if it does not exist. If you pass in null for the setXXX
Expand Down Expand Up @@ -82,7 +82,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public void <init>()
/// from: `public void <init>()`
/// The returned object must be released after use, by calling the [release] method.
///
/// Default Constructor.
Expand All @@ -107,7 +107,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JniResult Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void <init>(org.apache.pdfbox.cos.COSDictionary dic)
/// from: `public void <init>(org.apache.pdfbox.cos.COSDictionary dic)`
/// The returned object must be released after use, by calling the [release] method.
///
/// Constructor that is used for a preexisting dictionary.
Expand Down Expand Up @@ -137,7 +137,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public org.apache.pdfbox.cos.COSDictionary getCOSObject()
/// from: `public org.apache.pdfbox.cos.COSDictionary getCOSObject()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the underlying dictionary that this object wraps.
Expand All @@ -164,7 +164,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JniResult Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public java.lang.Object getPropertyStringValue(java.lang.String propertyKey)
/// from: `public java.lang.Object getPropertyStringValue(java.lang.String propertyKey)`
/// The returned object must be released after use, by calling the [release] method.
///
/// Return the properties String value.
Expand Down Expand Up @@ -202,7 +202,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getTitle()
/// from: `public java.lang.String getTitle()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the title of the document. This will return null if no title exists.
Expand All @@ -228,7 +228,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setTitle(java.lang.String title)
/// from: `public void setTitle(java.lang.String title)`
///
/// This will set the title of the document.
///@param title The new title for the document.
Expand Down Expand Up @@ -257,7 +257,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getAuthor()
/// from: `public java.lang.String getAuthor()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the author of the document. This will return null if no author exists.
Expand All @@ -283,7 +283,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setAuthor(java.lang.String author)
/// from: `public void setAuthor(java.lang.String author)`
///
/// This will set the author of the document.
///@param author The new author for the document.
Expand Down Expand Up @@ -312,7 +312,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getSubject()
/// from: `public java.lang.String getSubject()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the subject of the document. This will return null if no subject exists.
Expand All @@ -338,7 +338,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setSubject(java.lang.String subject)
/// from: `public void setSubject(java.lang.String subject)`
///
/// This will set the subject of the document.
///@param subject The new subject for the document.
Expand Down Expand Up @@ -367,7 +367,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getKeywords()
/// from: `public java.lang.String getKeywords()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the keywords of the document. This will return null if no keywords exists.
Expand All @@ -393,7 +393,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setKeywords(java.lang.String keywords)
/// from: `public void setKeywords(java.lang.String keywords)`
///
/// This will set the keywords of the document.
///@param keywords The new keywords for the document.
Expand Down Expand Up @@ -422,7 +422,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getCreator()
/// from: `public java.lang.String getCreator()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the creator of the document. This will return null if no creator exists.
Expand All @@ -448,7 +448,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setCreator(java.lang.String creator)
/// from: `public void setCreator(java.lang.String creator)`
///
/// This will set the creator of the document.
///@param creator The new creator for the document.
Expand Down Expand Up @@ -477,7 +477,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getProducer()
/// from: `public java.lang.String getProducer()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the producer of the document. This will return null if no producer exists.
Expand All @@ -503,7 +503,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setProducer(java.lang.String producer)
/// from: `public void setProducer(java.lang.String producer)`
///
/// This will set the producer of the document.
///@param producer The new producer for the document.
Expand Down Expand Up @@ -532,7 +532,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.util.Calendar getCreationDate()
/// from: `public java.util.Calendar getCreationDate()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the creation date of the document. This will return null if no creation date exists.
Expand All @@ -559,7 +559,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setCreationDate(java.util.Calendar date)
/// from: `public void setCreationDate(java.util.Calendar date)`
///
/// This will set the creation date of the document.
///@param date The new creation date for the document.
Expand Down Expand Up @@ -588,7 +588,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.util.Calendar getModificationDate()
/// from: `public java.util.Calendar getModificationDate()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the modification date of the document. This will return null if no modification date exists.
Expand All @@ -615,7 +615,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setModificationDate(java.util.Calendar date)
/// from: `public void setModificationDate(java.util.Calendar date)`
///
/// This will set the modification date of the document.
///@param date The new modification date for the document.
Expand Down Expand Up @@ -644,7 +644,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.lang.String getTrapped()
/// from: `public java.lang.String getTrapped()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the trapped value for the document.
Expand Down Expand Up @@ -672,7 +672,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JMethodIDPtr,
)>();

/// from: public java.util.Set<java.lang.String> getMetadataKeys()
/// from: `public java.util.Set<java.lang.String> getMetadataKeys()`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the keys of all metadata information fields for the document.
Expand Down Expand Up @@ -700,7 +700,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JniResult Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public java.lang.String getCustomMetadataValue(java.lang.String fieldName)
/// from: `public java.lang.String getCustomMetadataValue(java.lang.String fieldName)`
/// The returned object must be released after use, by calling the [release] method.
///
/// This will get the value of a custom metadata information field for the document.
Expand Down Expand Up @@ -736,7 +736,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>, ffi.Pointer<ffi.Void>)>();

/// from: public void setCustomMetadataValue(java.lang.String fieldName, java.lang.String fieldValue)
/// from: `public void setCustomMetadataValue(java.lang.String fieldName, java.lang.String fieldValue)`
///
/// Set the custom metadata value.
///@param fieldName The name of the custom metadata field.
Expand Down Expand Up @@ -769,7 +769,7 @@ class PDDocumentInformation extends jni.JObject {
jni.JThrowablePtr Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
ffi.Pointer<ffi.Void>)>();

/// from: public void setTrapped(java.lang.String value)
/// from: `public void setTrapped(java.lang.String value)`
///
/// This will set the trapped of the document. This will be
/// 'True', 'False', or 'Unknown'.
Expand Down
Loading

0 comments on commit 4eaec5a

Please sign in to comment.