New suggestion for packages failing because of SDK _macros dependen…

…cy. (#1388)
dart-lang · Jul 11, 2024 · e318df4 · e318df4
1 parent 84d9f7d
commit e318df4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.22.9
+
+- Updated suggestion for packages depending on SDK `_macros`.
+
 ## 0.22.8
 
 - Updated dependency: `tar: ^2.0.0`.

diff --git a/lib/src/report/static_analysis.dart b/lib/src/report/static_analysis.dart
@@ -90,10 +90,17 @@ Future<_AnalysisResult> _analyzePackage(PackageContext context) async {
   final dirs = await listFocusDirs(context.packageDir);
 
   try {
-    final resolveErrorMessage = await context.resolveErrorMessage;
-    if (resolveErrorMessage != null) {
+    final errorMessage = await context.resolveErrorMessage;
+    if (errorMessage != null) {
+      String? suggestion;
+      if (errorMessage.contains('from sdk which doesn\'t match any versions') &&
+          errorMessage.contains('requires _macros ')) {
+        suggestion =
+            'The SDK package `_macros` is an experimental feature which is only available in newer SDKs. '
+            'Increase your minimum SDK constraint for `pub.dev` to select such SDK for analysis.';
+      }
       return _AnalysisResult(
-        [Issue(resolveErrorMessage)],
+        [Issue(errorMessage, suggestion: suggestion)],
         [],
         [],
         context.usesFlutter ? 'flutter pub get' : 'dart pub get',

diff --git a/lib/src/version.dart b/lib/src/version.dart
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: pana
 description: PAckage aNAlyzer - produce a report summarizing the health and quality of a Dart package.
-version: 0.22.8
+version: 0.22.9-dev
 repository: https://github.com/dart-lang/pana
 topics:
   - tool