Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run and process dartdoc output to create pub-data.json and the coverage report. #1270

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Oct 27, 2023

@isoos
Copy link
Collaborator Author

isoos commented Nov 3, 2023

PTAL. I've removed the retry loop, deprecated its option and refactored the package_context code as we have discussed. I've opted for another small breaking change with DartdocResult, as we haven't used that class for anything recently.

Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit 963ff83 into dart-lang:master Nov 3, 2023
5 checks passed
@isoos isoos deleted the dartdoc branch November 3, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants