Fix: force global dartdoc activation from pub.dev. #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Nov 9, 2023
| @@ -1,6 +1,6 @@ | |||
| name: pana | |||
| description: PAckage aNAlyzer - produce a report summarizing the health and quality of a Dart package. | |||
| version: 0.21.41 | |||
| version: 0.21.42 | |||
There was a problem hiding this comment.
This is to be published straight away, right?
There was a problem hiding this comment.
yes, please do publish it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effects local development on
pub.dev, and also when running pana against dependencies on a private package repository. Without this change these services would need to pass-through proxypackage:dartdocand its dependencies, or otherwisepanashould allow pre-activation of the global scope.I think it is better to force this activation from
pub.devfor now, and if needed we can add option to override it - if the need for that is present.