Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded tar dependency + CI versions #1380

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jul 1, 2024

No description provided.

@isoos isoos requested review from jonasfj and sigurdm July 1, 2024 08:35
@isoos
Copy link
Collaborator Author

isoos commented Jul 1, 2024

Note: apparently the end2end tests behave differently on CI compared to my local environment, and the golden files don't match. Using a Dart SDK that is matching the stable Flutter's Dart SDK seems to solve the issue. In the future we should probably update the end2end test with configurable SDK selection that is downloading the SDK if needed.

@isoos isoos merged commit 8649259 into dart-lang:master Jul 1, 2024
2 checks passed
@isoos isoos deleted the upgrade branch July 1, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants