Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New text logging format + moving initialization to new method #1383

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jul 1, 2024

The new format is the combination of the current one (which blanks out the prefix on repeated lines) and pub-dev's worker format (which adds a timestamp in the prefix. It also makes the json logging simpler. The code refactor is in the second commit.

This is a less-important, but still required step before the pub worker can invoke the pana process without depending on it (while keeping the log format). As the next step, while the pub_worker still depends on pana as a library, it may use the separate method to initialize the logging.

@isoos isoos requested review from jonasfj and sigurdm July 1, 2024 15:11
@isoos isoos merged commit 5146beb into dart-lang:master Jul 1, 2024
5 checks passed
@isoos isoos deleted the logging branch July 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants