Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to package:dart_flutter_team_lints #1387

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Switch to package:dart_flutter_team_lints #1387

merged 1 commit into from
Jul 18, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jul 9, 2024

Manually disabling some lints for now, as they throw many errors.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from sigurdm July 11, 2024 08:00
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see any issues here.

@@ -8,6 +8,8 @@ analyzer:
unused_local_variable: error
dead_code: error
deprecated_member_use_from_same_package: ignore
lines_longer_than_80_chars: ignore
avoid_dynamic_calls: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that outside this PR, but maybe we should just adopt dart_flutter_team_lints without any custom options.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but there are a bunch of violations, so better to split that up into separate PRs.

@mosuem mosuem merged commit 3314a87 into master Jul 18, 2024
5 checks passed
@mosuem mosuem deleted the applyLints branch July 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants