Expose wasm readiness analysis in the report (without any score) #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Aug 15, 2024
isoos
commented
- Add badges for Wasm compatibility pub-dev#6785
- also did a refactor that may be one step towards some consolidation between tagging and reporting
sigurdm
reviewed
Aug 15, 2024
lib/src/report/multi_platform.dart
Outdated
|
|
||
| Future<Subsection> _createWasmSubsection(PackageContext context) async { | ||
| final tr = await context.staticAnalysis; | ||
| final description = 'WASM readiness'; |
There was a problem hiding this comment.
Perhaps:
Suggested change
| final description = 'WASM readiness'; | |
| final description = 'WASM compatibility'; |
| @@ -78,6 +78,10 @@ Could not determine supported platforms as package resolution failed. | |||
| Run `dart pub get` for more information. | |||
| </details> | |||
|
|
|||
| ### [x] 0/0 points: WASM readiness | |||
|
|
|||
| Unable to detect compatibility with runtime `wasm`. | |||
There was a problem hiding this comment.
We need a reason here. Is it because the resolution failed?
There was a problem hiding this comment.
Either the resolution failed or there are error-level issues in the code, which prevent static analysis. As these are exposed at the other parts of the report, I don't think we need to repeat them here.
|
Love this! thanks! |
sigurdm
approved these changes
Aug 20, 2024
jonasfj
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.