Detect library hrefs with or without ending slash. #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Nov 28, 2024
| @@ -17,6 +17,7 @@ bool isHrefALibrary(String? href) { | |||
| if (href.endsWith('.html')) { | |||
| return false; | |||
| } | |||
| // libraries have no slash in their hrefs | |||
| return !href.contains('/'); | |||
| final segments = href.split('/').where((s) => s.isNotEmpty).toList(); | |||
There was a problem hiding this comment.
This also removes empty segments in the middle a//b->a/b is that ever a problem? should we test for an empty segment only at the end?
There was a problem hiding this comment.
In this specific case, it would be considered as a bug in dartdoc, however, it doesn't hurt if we remove only the last one. Done.
sigurdm
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is assuming that the new href URLs in dartdoc will get an ending slash: dart-lang/dartdoc#3936