pub version.dart as a general purpose semantic versioning library #972
Comments
|
<img src="https://avatars.githubusercontent.com/u/654526?v=3" align="left" width="48" height="48"hspace="10"> Comment by financeCoding Added Area-Pub label. |
|
<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo Removed Type-Defect, Area-Pub labels. |
|
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Pub's semantic versioning implementation follows version 2.0.0-rc.1 of the spec, which is not the most recent version. We have good reasons for doing so in Pub, but it seems weird to create a semantic versioning package that doesn't use an up-to-date version of the spec. What's your use case for wanting to use this? cc @munificent. |
|
<img src="https://avatars.githubusercontent.com/u/654526?v=3" align="left" width="48" height="48"hspace="10"> Comment by financeCoding I use that file to help sort versions of pub packages. I'm not aware of any semantic versioning libraries on pub, since this is specific to pubspec files I think that doubles the need for it to be available as a general purpose library. I guess a full solution would be to have pub in general as a library. |
|
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd Any issues calling the package and library pub_versioning or similar? |
|
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Yeah, I've thought about pulling this into a package for a while, but Nathan's concern is mine too. I really think semver 2.0.0-rc.1 has better semantics, but it would feel a bit strange making a "semver" or "version" package that relied on that implicitly. |
|
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd Adam, did we copy that code over to our dartdocs hosting project? Bob, Nathan, is it an issue of naming the package? Can we name it/describe it such that expectations are set correctly and no one is mislead? Or, maybe we can import pub/version.dart ? :) |
|
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
Not so much naming as identity. If it's a "pub versioning" package, then its semantics are clear, but it's less widely usable. (Lots of things that aren't pub deal with versions!) If it's a "semver" package, then it's widely usable, but it's behavior may be surprising. |
|
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd Gotcha, makes sense. Agree, we don't want to call this semver. Is there a middle ground here, to offer the ability to import "pub/version.dart" from a pub package? That way, we don't need to maintain a separate package just for version.dart, but we do make it easier for developers to build mashups and work with our packages. |
|
<img src="https://avatars.githubusercontent.com/u/654526?v=3" align="left" width="48" height="48"hspace="10"> Comment by financeCoding I've just copied it over, also not the first thing I've found valuable hidden inside pub ;) I'm fine with copying until something general gets produced. |
|
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
No, it would have to be a package. I wouldn't mind something like that, but until we have time to think about it more (like, should other stuff be in there too and if so, does that affect the name of the package?), the easiest solution is to just copy it. :-/
We actually try to pull a lot of that stuff out into packages (watcher, barback, path, scheduled_test, http, oauth2, etc.) What else have you found that you would want in a package that isn't already? |
|
<img src="https://avatars.githubusercontent.com/u/654526?v=3" align="left" width="48" height="48"hspace="10"> Comment by financeCoding You have mentioned the packages. Just a statement of the gems that once lived in pub. |
|
<img src="https://avatars.githubusercontent.com/u/444270?v=3" align="left" width="48" height="48"hspace="10"> Comment by seaneagan could be useful for issue dart-lang/sdk#19389 |
|
<img src="https://avatars.githubusercontent.com/u/444270?v=3" align="left" width="48" height="48"hspace="10"> Comment by seaneagan Just saw this: |
|
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd This would be nice, so dartdocs.org didn't have to copy code out of pub. Maybe we'll do it later? Removed Area-Pkg label. |
|
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd This came up again. Would like to reopen as a Low-Pri for us to discuss a name, which might be the blocker? fwiw we have a couple of places that need the exact version semantics that pub shares: dartdocs.org Removed Priority-Unassigned label. |
|
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 I wouldn't be wholly opposed to releasing a pub_semver package. |
|
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd name lgtm |
|
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent pub_semver it is! Set owner to @munificent. |
<img src="https://avatars.githubusercontent.com/u/654526?v=3" align="left" width="96" height="96"hspace="10"> Issue by financeCoding
Originally opened as dart-lang/sdk#18555
If you know the Area- label, please set it and change status to Triaged.*
If you are reporting a problem in the Dart Editor, please open the Help ->
About Dart Editor dialog and add the Dart SDK version number to this
report. If you prefer, you can use the 'Send Feedback' button in the Dart
Editor to file a report that will contain this information and additional
context helpful for debugging the problem.
The text was updated successfully, but these errors were encountered: