Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub version.dart as a general purpose semantic versioning library #18555

Closed
DartBot opened this issue Apr 30, 2014 · 20 comments
Closed

pub version.dart as a general purpose semantic versioning library #18555

DartBot opened this issue Apr 30, 2014 · 20 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 30, 2014

This issue was originally filed by @financecoding


If you know the Area- label, please set it and change status to Triaged.*

If you are reporting a problem in the Dart Editor, please open the Help ->
About Dart Editor dialog and add the Dart SDK version number to this
report. If you prefer, you can use the 'Send Feedback' button in the Dart
Editor to file a report that will contain this information and additional
context helpful for debugging the problem.

@DartBot
Copy link
Author

DartBot commented Apr 30, 2014

This comment was originally written by @financecoding


version.dart should be available as a pub library for all dart users

https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/_internal/pub/lib/src/version.dart


Added Area-Pub label.
Changed the title to: "pub version.dart as a general purpose semantic versioning library ".

@kevmoo
Copy link
Member

kevmoo commented Apr 30, 2014

Removed Type-Defect, Area-Pub labels.
Added Type-Enhancement, Area-Pkg, Triaged labels.

@nex3
Copy link
Member

nex3 commented Apr 30, 2014

Pub's semantic versioning implementation follows version 2.0.0-rc.1 of the spec, which is not the most recent version. We have good reasons for doing so in Pub, but it seems weird to create a semantic versioning package that doesn't use an up-to-date version of the spec.

What's your use case for wanting to use this?


cc @munificent.

@DartBot
Copy link
Author

DartBot commented Apr 30, 2014

This comment was originally written by @financecoding


I use that file to help sort versions of pub packages. I'm not aware of any semantic versioning libraries on pub, since this is specific to pubspec files I think that doubles the need for it to be available as a general purpose library. I guess a full solution would be to have pub in general as a library.

@sethladd
Copy link
Contributor

Any issues calling the package and library pub_versioning or similar?

@munificent
Copy link
Member

Yeah, I've thought about pulling this into a package for a while, but Nathan's concern is mine too. I really think semver 2.0.0-rc.1 has better semantics, but it would feel a bit strange making a "semver" or "version" package that relied on that implicitly.

@sethladd
Copy link
Contributor

Adam, did we copy that code over to our dartdocs hosting project?

Bob, Nathan, is it an issue of naming the package? Can we name it/describe it such that expectations are set correctly and no one is mislead?

Or, maybe we can import pub/version.dart ? :)

@munificent
Copy link
Member

Bob, Nathan, is it an issue of naming the package?

Not so much naming as identity. If it's a "pub versioning" package, then its semantics are clear, but it's less widely usable. (Lots of things that aren't pub deal with versions!) If it's a "semver" package, then it's widely usable, but it's behavior may be surprising.

@sethladd
Copy link
Contributor

Gotcha, makes sense. Agree, we don't want to call this semver.

Is there a middle ground here, to offer the ability to import "pub/version.dart" from a pub package? That way, we don't need to maintain a separate package just for version.dart, but we do make it easier for developers to build mashups and work with our packages.

@DartBot
Copy link
Author

DartBot commented Apr 30, 2014

This comment was originally written by @financecoding


I've just copied it over, also not the first thing I've found valuable hidden inside pub ;)

I'm fine with copying until something general gets produced.

@munificent
Copy link
Member

Is there a middle ground here, to offer the ability to import "pub/version.dart" from a pub package? That way, we don't need to maintain a separate package just for version.dart,

No, it would have to be a package. I wouldn't mind something like that, but until we have time to think about it more (like, should other stuff be in there too and if so, does that affect the name of the package?), the easiest solution is to just copy it. :-/

not the first thing I've found valuable hidden inside pub ;)

We actually try to pull a lot of that stuff out into packages (watcher, barback, path, scheduled_test, http, oauth2, etc.) What else have you found that you would want in a package that isn't already?

@DartBot
Copy link
Author

DartBot commented May 1, 2014

This comment was originally written by @financecoding


You have mentioned the packages. Just a statement of the gems that once lived in pub.

@DartBot
Copy link
Author

DartBot commented Jun 12, 2014

This comment was originally written by @seaneagan


could be useful for issue #19389

@DartBot
Copy link
Author

DartBot commented Jun 28, 2014

This comment was originally written by @seaneagan


Just saw this:

http://pub.dartlang.org/packages/semver

@sethladd
Copy link
Contributor

This would be nice, so dartdocs.org didn't have to copy code out of pub. Maybe we'll do it later?


Removed Area-Pkg label.
Added NotPlanned label.

@sethladd
Copy link
Contributor

sethladd commented Sep 5, 2014

This came up again. Would like to reopen as a Low-Pri for us to discuss a name, which might be the blocker?

fwiw we have a couple of places that need the exact version semantics that pub shares:

dartdocs.org
pub.drone.io
Nicolas's new script to analyze pub packages


Removed Priority-Unassigned label.
Added Priority-Low, Area-Pub, Triaged labels.

@nex3
Copy link
Member

nex3 commented Sep 5, 2014

I wouldn't be wholly opposed to releasing a pub_semver package.

@sethladd
Copy link
Contributor

sethladd commented Sep 5, 2014

name lgtm

@munificent
Copy link
Member

pub_semver it is!


Set owner to @munificent.
Removed Priority-Low label.
Added Priority-Medium, Accepted labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#972.

@kevmoo kevmoo added the type-enhancement A request for a change that isn't a bug label Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants