Annotate fail with @alwaysThrows, Remove unreachable throws #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-lang/sdk#31384 was fixed in dart-lang/sdk@0a6253312f Available in Dart 2.0.0-dev.12.0
|
Feel free to squash/merge and delete the branch if approve... |
kevmoo
referenced
this pull request
in dart-lang/sdk
Dec 16, 2017
The meta package version 1.1.0 includes a new `alwaysThrows`, which developers can use to annotate methods that always throw. This helps to avoid erroneous DEAD_CODE warnings from analyzer. Bug: #31384 Change-Id: I70e2469b4f3a0d2c87064851160b268ea2259807 Reviewed-on: https://dart-review.googlesource.com/26563 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk#31384 was fixed in
dart-lang/sdk@0a6253312f
Available in Dart 2.0.0-dev.12.0