Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

fix param types on methods in _EmptyVersion #9

Merged
merged 1 commit into from
Sep 21, 2015
Merged

fix param types on methods in _EmptyVersion #9

merged 1 commit into from
Sep 21, 2015

Conversation

devoncarew
Copy link
Member

Fix two type issues found by ddc - the params of two methods differed from what was defined in the parent class:

Invalid override. The type of _EmptyVersion.allowsAll ((Version) → bool) is not a subtype of VersionConstraint.allowsAll ((VersionConstraint) → bool). (package:pub_semver/src/version_constraint.dart, line 212, col 3)
Invalid override. The type of _EmptyVersion.allowsAny ((Version) → bool) is not a subtype of VersionConstraint.allowsAny ((VersionConstraint) → bool). (package:pub_semver/src/version_constraint.dart, line 213, col 3)

(see also dart-atom/dart#327)

@nex3
Copy link
Member

nex3 commented Sep 21, 2015

Can you add a CHANGELOG entry and bump the pubspec version?

@devoncarew
Copy link
Member Author

Sure - rev'd from 1.2.1 to 1.2.2 - will squash the commits.

nex3 added a commit that referenced this pull request Sep 21, 2015
fix param types on methods in _EmptyVersion
@nex3 nex3 merged commit 4e29ab5 into master Sep 21, 2015
@kevmoo kevmoo deleted the param_type branch July 19, 2018 19:11
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
fix param types on methods in _EmptyVersion
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants