Skip to content

Commit

Permalink
[docs] Update link to cherry pick issue template
Browse files Browse the repository at this point in the history
Change-Id: Ib7780a1226cef2e7a906b477d87d66053d71c7d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404843
Reviewed-by: Ömer Ağacan <omersa@google.com>
  • Loading branch information
athomas committed Jan 17, 2025
1 parent 5daaead commit 8f815ce
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions docs/Cherry-picks-to-a-release-channel.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,26 +108,26 @@ Edit the changelist's commit message with a link to the cherry-pick request:
Cherry-pick-request: https://github.com/dart/sdk/issues/56781234
```

Send the changelist for review. Await the appropriate consensus and approval via the
`cherry-pick-request` for them or any OWNER to review the changelist.
Send the changelist for review. Await the appropriate consensus and approval
via the `cherry-pick-request` for them or any OWNER to review the changelist.

## Submitting the cherry-pick

Once the cherry-pick issue is approved and the changelist is reviewed, the
cherry-pick author will submit it to the commit queue. The tryjobs will compare
the test results with the previous commit on the beta/stable branch and fail if
any regressions are introduced. If any regressions must be introduced, or the
try builders don't work on the older beta/stable code, then bypass the commit queue
by force submitting.
Once the cherry-pick issue is approved and the changelist is reviewed, the
cherry-pick author will submit it to the commit queue. The tryjobs will compare
the test results with the previous commit on the beta/stable branch and fail if
any regressions are introduced. If any regressions must be introduced, or the
try builders don't work on the older beta/stable code, then bypass the commit
queue by force submitting.

The release engineers will apply the `cherry-pick-merged` label and the cherry-pick
will be automatically bundled into the next hotfix release of beta/stable and no
further actions are required.
The release engineers will apply the `cherry-pick-merged` label and the
cherry-pick will be automatically bundled into the next hotfix release of
beta/stable and no further actions are required.

Once the cherry-pick has landed in a hotfix release, the release engineering team
will close the cherry-pick issue.
Once the cherry-pick has landed in a hotfix release, the release engineering
team will close the cherry-pick issue.

[cherry-pick-template]: https://github.com/dart-lang/sdk/issues/new?assignees=mit-mit%2Cwhesse%2Cathomas%2Cvsmenon%2Citsjustkevin&labels=cherry-pick-review&template=2_cherry_pick.yml&title=%5BCP%5D+%3Ctitle%3E
[cherry-pick-template]: https://github.com/dart-lang/sdk/issues/new?template=5_cherry_pick.yml

## Cherry-picking a commit in a dependency

Expand Down

0 comments on commit 8f815ce

Please sign in to comment.