remove #177 workaround

this issue was fixed R=vsm@google.com Review URL: https://codereview.chromium.org/1142553002
dart-lang · May 14, 2015 · 995e0f0 · 995e0f0
1 parent 3377d2b
commit 995e0f0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/pkg/dev_compiler/lib/runtime/dart/_isolate_helper.js b/pkg/dev_compiler/lib/runtime/dart/_isolate_helper.js
@@ -778,12 +778,13 @@ var async = dart.import(async);
     }
     [_runHelper]() {
       if (exports.globalWindow != null) {
+        // Function next: () → dynamic
         let next = (() => {
           if (!dart.notNull(this.runIteration()))
             return;
-          async.Timer.run(dart.as(next, __CastType2));
+          async.Timer.run(next);
         }).bind(this);
-        dart.dcall(next);
+        next();
       } else {
         while (this.runIteration()) {
         }
@@ -1381,7 +1382,6 @@ var async = dart.import(async);
   }
   CapabilityImpl[dart.implements] = () => [isolate.Capability];
   dart.defineNamedConstructor(CapabilityImpl, '_internal');
-  let __CastType2 = dart.typedef('__CastType2', () => dart.functionType(dart.void, []));
   // Exports:
   exports.enterJsAsync = enterJsAsync;
   exports.leaveJsAsync = leaveJsAsync;

diff --git a/pkg/dev_compiler/test/generated_sdk/lib/_internal/compiler/js_lib/isolate_helper.dart b/pkg/dev_compiler/test/generated_sdk/lib/_internal/compiler/js_lib/isolate_helper.dart
@@ -652,12 +652,10 @@ class _EventLoop {
   void _runHelper() {
     if (globalWindow != null) {
       // Run each iteration from the browser's top event loop.
-      // TODO(vsm): Revert to original pattern.
-      // See: https://github.com/dart-lang/dev_compiler/issues/177
-      Function next = () {
+      next() {
         if (!runIteration()) return;
         Timer.run(next);
-      };
+      }
       next();
     } else {
       // Run synchronously until no more iterations are available.

diff --git a/pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart b/pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart
@@ -652,12 +652,10 @@ class _EventLoop {
   void _runHelper() {
     if (globalWindow != null) {
       // Run each iteration from the browser's top event loop.
-      // TODO(vsm): Revert to original pattern.
-      // See: https://github.com/dart-lang/dev_compiler/issues/177
-      Function next = () {
+      next() {
         if (!runIteration()) return;
         Timer.run(next);
-      };
+      }
       next();
     } else {
       // Run synchronously until no more iterations are available.