Skip to content

Commit

Permalink
[deps] Rev benchmark_harness dependency
Browse files Browse the repository at this point in the history
benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/0ae822e..f4ed0fc):
  f4ed0fc  Wed Jul 6 03:45:31 2022 -0700  Leaf Petersen  Fix harness to not call timer repeatedly in the measured loop. (#38)

Change-Id: I5843e1700af29939d69c80eab7348bf39bbcd0d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250742
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
  • Loading branch information
mraleph authored and Commit Bot committed Jul 7, 2022
1 parent d3ea8bf commit 9c3c388
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ vars = {
"args_rev": "73e8d3b55cbedc9765f8e266f3422d8914f8e62a",
"async_rev": "f3ed5f690e2ec9dbe1bfc5184705575b4f6480e5",
"bazel_worker_rev": "9710de6c9c70b1b583183db9d9721ba64e5a16fe",
"benchmark_harness_rev": "0ae822e264e410e9f1e927daea68601cc54906ef",
"benchmark_harness_rev": "f4ed0fcac4c284580263f0c548664dd548c9cca3",
"boolean_selector_rev": "1d3565e2651d16566bb556955b96ea75018cbd0c",
"boringssl_gen_rev": "ced85ef0a00bbca77ce5a91261a5f2ae61b1e62f",
"boringssl_rev": "87f316d7748268eb56f2dc147bd593254ae93198",
Expand Down
9 changes: 8 additions & 1 deletion runtime/tests/vm/dart/splay_ephemeron_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,14 @@ class Splay extends BenchmarkBase {

static void main() {
mysetup();
new Splay().report();
// Don't use benchmark_harness - exercise runtime is not stable (so
// benchmark_harness measuring approach is meaningless for such benchmark
// anyway).
final sw = Stopwatch()..start();
final benchmark = new Splay();
while (sw.elapsedMilliseconds < 2000) {
benchmark.exercise();
}
tearDown();
}
}
Expand Down
9 changes: 8 additions & 1 deletion runtime/tests/vm/dart/splay_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ class Splay extends BenchmarkBase {

static void main() {
mysetup();
new Splay().report();
// Don't use benchmark_harness - exercise runtime is not stable (so
// benchmark_harness measuring approach is meaningless for such benchmark
// anyway).
final sw = Stopwatch()..start();
final benchmark = new Splay();
while (sw.elapsedMilliseconds < 2000) {
benchmark.exercise();
}
tearDown();
}
}
Expand Down
9 changes: 8 additions & 1 deletion runtime/tests/vm/dart_2/splay_ephemeron_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ class Splay extends BenchmarkBase {

static void main() {
mysetup();
new Splay().report();
// Don't use benchmark_harness - exercise runtime is not stable (so
// benchmark_harness measuring approach is meaningless for such benchmark
// anyway).
final sw = Stopwatch()..start();
final benchmark = new Splay();
while (sw.elapsedMilliseconds < 2000) {
benchmark.exercise();
}
tearDown();
}
}
Expand Down
9 changes: 8 additions & 1 deletion runtime/tests/vm/dart_2/splay_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,14 @@ class Splay extends BenchmarkBase {

static void main() {
mysetup();
new Splay().report();
// Don't use benchmark_harness - exercise runtime is not stable (so
// benchmark_harness measuring approach is meaningless for such benchmark
// anyway).
final sw = Stopwatch()..start();
final benchmark = new Splay();
while (sw.elapsedMilliseconds < 2000) {
benchmark.exercise();
}
tearDown();
}
}
Expand Down

0 comments on commit 9c3c388

Please sign in to comment.