Skip to content

Commit

Permalink
fix default warning level
Browse files Browse the repository at this point in the history
  • Loading branch information
John Messerly committed Sep 29, 2015
1 parent 47bab05 commit c761b42
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions pkg/dev_compiler/lib/src/options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class CompilerOptions {
this.useColors: true,
this.help: false,
this.version: false,
this.logLevel: Level.SEVERE,
this.logLevel: Level.WARNING,
this.serverMode: false,
this.enableHashing: false,
this.widget: true,
Expand All @@ -181,8 +181,7 @@ CompilerOptions parseOptions(List<String> argv, {bool forceOutDir: false}) {
if (enableHashing == null) {
enableHashing = serverMode;
}
// TODO(jmesserly): shouldn't level always default to warning?
var logLevel = serverMode ? Level.WARNING : Level.SEVERE;
var logLevel = Level.WARNING;
var levelName = args['log'];
if (levelName != null) {
levelName = levelName.toUpperCase();
Expand Down Expand Up @@ -313,7 +312,7 @@ final ArgParser argParser = StrongModeOptions.addArguments(new ArgParser()
defaultsTo: _CLOSURE_DEFAULT)
..addFlag('force-compile',
help: 'Compile code with static errors', defaultsTo: false)
..addOption('log', abbr: 'l', help: 'Logging level (defaults to severe)')
..addOption('log', abbr: 'l', help: 'Logging level (defaults to warning)')
..addFlag('dump-info',
abbr: 'i', help: 'Dump summary information', defaultsTo: null)
..addOption('v8-binary',
Expand Down

0 comments on commit c761b42

Please sign in to comment.