Skip to content

Commit

Permalink
Revert "Workaround #537"
Browse files Browse the repository at this point in the history
Undoing this.  Paul fixed this in 1.17.  We'll need to run with 1.17 builds going forward, but we need that for other reasons.

Fixes #537

R=jacobr@google.com

Review URL: https://codereview.chromium.org/1936693002 .
  • Loading branch information
vsmenon committed May 3, 2016
1 parent 6d8dc11 commit dc8e00b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions pkg/dev_compiler/lib/runtime/dart_sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -29344,8 +29344,8 @@ dart_library.library('dart_sdk', null, /* Imports */[
const _checkInsertIndex = Symbol('_checkInsertIndex');
js.JsArray$ = dart.generic(E => {
class JsArray extends dart.mixin(js.JsObject, collection.ListMixin$(E)) {
static new() {
return new (js.JsArray$(E))._fromJs([]);
JsArray() {
super._fromJs([]);
}
from(other) {
super._fromJs((() => {
Expand Down Expand Up @@ -29446,7 +29446,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
dart.defineNamedConstructor(JsArray, '_fromJs');
dart.setSignature(JsArray, {
constructors: () => ({
new: [js.JsArray$(E), []],
JsArray: [js.JsArray$(E), []],
from: [js.JsArray$(E), [core.Iterable$(E)]],
_fromJs: [js.JsArray$(E), [dart.dynamic]]
}),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {
/**
* Creates a new JavaScript array.
*/
// TODO(vsm): Making this a factory to workaround #537.
factory JsArray() { return new JsArray._fromJs([]); }
JsArray() : super._fromJs([]);

/**
* Creates a new JavaScript array and initializes it to the contents of
Expand Down

0 comments on commit dc8e00b

Please sign in to comment.