Skip to content

Commit

Permalink
[test_runner] Use package:args
Browse files Browse the repository at this point in the history
* Use lowercase-with-hyphens for option names
* Add backwards compatible aliases_with_underscores.
* Deny list `reset-browser-configuration`.
* Add more tests.

Bug: b/232495224
Change-Id: Ife56c48450b5e15577c4aec859355e80c2f57bdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245366
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
  • Loading branch information
athomas authored and Commit Bot committed May 24, 2022
1 parent a6fcb56 commit ddad653
Show file tree
Hide file tree
Showing 8 changed files with 550 additions and 641 deletions.
2 changes: 1 addition & 1 deletion pkg/analyzer/tool/fasta_migration_progress.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ if [[ $logfile == '' ]]; then
# delete=1
python3 tools/test.py -m release --checked --use-sdk \
--vm-options="-DuseFastaParser=true" \
--print_passing_stdout \
--print-passing-stdout \
pkg/analy > $logfile
fi

Expand Down
2 changes: 1 addition & 1 deletion pkg/test_runner/lib/src/configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ class TestConfiguration {
/// We allow our code to have been cross compiled, i.e., that there is an X
/// in front of the arch. We don't allow both a cross compiled and a normal
/// version to be present (except if you specifically pass in the
/// build_directory).
/// build-directory).
String _calculateDirectory() {
// Capitalize the mode name.
var result =
Expand Down
Loading

0 comments on commit ddad653

Please sign in to comment.