Skip to content

Commit

Permalink
Adjust test status for debugging in Dartium.
Browse files Browse the repository at this point in the history
"Reverting 25970"

BUG=

Review URL: https://codereview.chromium.org//22721003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25972 260f80e4-7a28-3924-810f-c04153c831b5
  • Loading branch information
efortuna committed Aug 9, 2013
1 parent 7312ba7 commit e8c1c17
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 18 deletions.
17 changes: 0 additions & 17 deletions sdk/lib/html/dartium/html_dartium.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9734,23 +9734,6 @@ abstract class Element extends Node implements ParentNode, ChildNode {
}


/**
* Checks if this element matches the CSS selectors.
*/
@Experimental()
bool matches(String selectors) {
if (JS('bool', '!!#.matches', this)) {
return JS('bool', '#.matches(#)', this, selectors);
} else if (JS('bool', '!!#.webkitMatchesSelector', this)) {
return JS('bool', '#.webkitMatchesSelector(#)', this, selectors);
} else if (JS('bool', '!!#.mozMatchesSelector', this)) {
return JS('bool', '#.mozMatchesSelector(#)', this, selectors);
} else if (JS('bool', '!!#.msMatchesSelector', this)) {
return JS('bool', '#.msMatchesSelector(#)', this, selectors);
}
throw new UnsupportedError("Not supported on this platform");
}

Element _templateInstanceRef;

// Note: only used if `this is! TemplateElement`
Expand Down
2 changes: 2 additions & 0 deletions tests/html/html.status
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ webgl_1_test: Pass, Fail # Issue 8219
[ $compiler == none && ($runtime == drt || $runtime == dartium) ]
request_animation_frame_test: Skip # drt hangs; requestAnimationFrame not implemented
worker_api_test: Fail # http://dartbug.com/10223
element_test/click: Fail #TODO(efortuna)
element_test/eventDelegation: Fail #TODO(efortuna)

[ $compiler == none && ($runtime == drt || $runtime == dartium) && $system == windows]
websql_test: Skip # Issue 4941: stderr contains a backtrace.
Expand Down
3 changes: 2 additions & 1 deletion tools/dom/templates/html/impl/impl_Element.darttemplate
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,6 @@ $if DART2JS
throw new ArgumentError("Invalid position ${where}");
}
}
$endif

/**
* Checks if this element matches the CSS selectors.
Expand Down Expand Up @@ -904,6 +903,8 @@ $endif
} while(includeAncestors && elem != null);
return false;
}
$else
$endif

$if DART2JS
@Creates('Null') // Set from Dart code; does not instantiate a native type.
Expand Down

0 comments on commit e8c1c17

Please sign in to comment.