Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test.dart does not read all of stderr after a crash for batch runner #2299

Closed
DartBot opened this issue Mar 25, 2012 · 1 comment
Closed

test.dart does not read all of stderr after a crash for batch runner #2299

DartBot opened this issue Mar 25, 2012 · 1 comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@DartBot
Copy link

DartBot commented Mar 25, 2012

This issue was originally filed by zundel@google.com

After a crash, dartc will usually have a stack trace which should be printed. After recent changes, it seems the stderr from a crash is lost because the process exit handler executes first.

I took a stab at fixing this which succeeds in fixing the reading of stderr issue, but it fails to restart the batch process.
  http://codereview.chromium.org/9852001/diff/1/tests/language/src/BoolTest.dart

It patches BooleanTest to fail (a normal failure), and dartc to crash with a 'RuntimeException' on the fifth test in a batch.
@whesse
Copy link
Contributor

whesse commented Jun 11, 2012

Fixed in r8058.

Added Fixed label.

@DartBot DartBot added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Jun 11, 2012
dart-bot pushed a commit that referenced this issue Jan 16, 2020
@sigurdm
Bump pub revision in DEPS
be1ddc8 
New commits included in this revision:
```
$ git log --pretty=oneline 4d8ecbd409d773fec47da33b7e6c8db0b51487fd..429a06039d185149f387a65e3503b0693ce6d24e
429a06039d185149f387a65e3503b0693ce6d24e (HEAD -> master, origin/master, origin/HEAD) Parallel fetching of available versions (#2280)
6705b085b9bf4754a4c8002a070f436f115dc4d1 Retry on all SocketExceptions (#2254)
a1820273b9f3c7bb5a13d26cd14d30d5bab187ae Use a unqiue file name for the snapshot during testing. (#2303)
72686563e767f8a359e48a267a2c323953a6a0ef Include osx and windows testing on Travis (#2299)
a7a66821d13920b9b22cc394dfa55c679e971e40 Fail travis for lints and warnings (#2301)
25aa24c023453f064dad8f3cce1bbd55269d0efa Omit languageVersion when there is no SDK constraint (#2300)
82e60a3dcb3afe753563e7d304827fb650bc4833 Use LOCALAPPDATA for system cache on windows (#2297)
ceaa86f2c7eb35f044b4c202268a17361de68d13 Enforce and fix lints from package:pedantic (#2291)
6ce1606564352c305bd0f6d97704f0f7f6ebbca0 Use more collection literals for args (#2293)
be245e6baeebb71aaf3b3a260fcfbbb011a9a7e0 Rename some test utilities from Mock to Fake (#2294)
f7638ce85298df7d9e73d717dd4d81f499681720 Refactor Set.add following !Set.contains (#2295)
390022b24bc076cb934385936ac7904f045a75ba Filter out `null` from `getCachedPackages`. (#2292)
0eea0c4421ed0b83c8597b62dacf68b93de172b9 Fix existing hints and lints (#2290)
7cf2fe860a40517ccb65f5efdda9e4dc350142c3 promote strict deps failures to errors from warnings (#2289)
```

Change-Id: I62782b29e16092114940df00811bfdd20c8045fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131839
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 11, 2023
@devoncarew
[deps] rev ecosystem, fixnum, http_parser, leak_tracker, mockito, pat…
034c6d7 
…h, protobuf, sync_http, test, tools, web, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/79a1bc5..ce707fb):
  ce707fb  2023-12-06  Moritz  Use Flutter in `health.yaml` (#206)

fixnum (https://github.com/dart-lang/fixnum/compare/6b0888c..3e08c0d):
  3e08c0d  2023-12-04  Kevin Moore  drop outdated lints (#123)

http_parser (https://github.com/dart-lang/http_parser/compare/1cf5b7c..224c1a9):
  224c1a9  2023-12-04  Kevin Moore  drop outdated lints (#82)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/a618a55..8644f8b):
  8644f8b  2023-12-11  Lucas.Xu  chore: bump leak_tracking_flutter_testing version to 1.0.12-wip (#192)
  cac195d  2023-12-11  Binni Goel  Fix. typos in leak_tracker (#189)
  9fd7932  2023-12-11  Lucas.Xu  fix: add missing on leak callback (#190)
  1ab3140  2023-12-08  Lucas.Xu  chore: refactor code style (#186)

mockito (https://github.com/dart-lang/mockito/compare/fb8a2b5..57a7c82):
  57a7c82  2023-12-06  Copybara-Service  Merge pull request #721 from Sese-Schneider:master
  c5de658  2023-12-06  Sese Schneider  Apply suggestions from code review
  1a652b8  2023-11-21  Sebastian Schneider  Use `posix` style for local imports

path (https://github.com/dart-lang/path/compare/18ec71f..115ea2a):
  115ea2a  2023-12-05  Devon Carew  rev the version of lints used; prep for publishing (#155)

protobuf (https://github.com/dart-lang/protobuf/compare/bb19774..20ec685):
  20ec685  2023-12-05  Ömer Sinan Ağacan  Small PbList improvements (#906)

sync_http (https://github.com/dart-lang/sync_http/compare/d8e9f3d..f96db95):
  f96db95  2023-12-05  Kevin Moore  Latest lints, require Dart 3.0, use mini-libraries (#42)

test (https://github.com/dart-lang/test/compare/9fffb48..43ff5bf):
  43ff5bf9  2023-12-11  Ömer Sinan Ağacan  Fix Dart2Wasm spelling (#2155)
  7d61eef9  2023-12-08  Derek Xu  Update frontend_server_client constraint to allow version 4.0.0 (#2153)
  001c5381  2023-12-07  Jacob MacDonald  fix precompiled vm tests loaded from a package: uri (#2152)
  fb3b5725  2023-12-05  Nate Bosch  Use package: URIs for imports when possible (#2148)
  03cc56ec  2023-12-05  Jacob MacDonald  mark flaky windows test as skipped (#2151)
  6e7e4fa8  2023-12-05  Jacob MacDonald  Add regression test for relative imports in tests under `lib` (#2147)
  84c366a7  2023-12-05  Jacob MacDonald  fix broken tests (#2149)
  e49ae54b  2023-12-05  Jacob MacDonald  Promote dart2wasm compiler support to the stable browser platform. (#2144)

tools (https://github.com/dart-lang/tools/compare/c63dcb5..ed81684):
  ed81684  2023-12-06  Elias Yishak  Fix consent message formatting (#215)
  c4d515a  2023-12-05  Elias Yishak  Enum + event added for `commandUsageValues` (#211)

web (https://github.com/dart-lang/web/compare/865aeaf..acf0beb):
  acf0beb  2023-12-07  Devon Carew  fixes to the return types of several Node helper extension methods (#121)
  9d7b33e  2023-12-06  Srujan Gaddam  Handle Dart SDK change to extension types (#116)
  0ae45ec  2023-12-05  Devon Carew  Update README.md (#117)
  34b3618  2023-12-05  Devon Carew  have web.dart export the helpers; deprecate helpers.dart (#115)

webdev (https://github.com/dart-lang/webdev/compare/63e09e5..8375cd6):
  8375cd66  2023-12-08  Elliott Brooks  Add popup for copying the app ID (#2299)

Change-Id: Ibf5f5eca74c56bf31d50bddabbe9da2a2e6fd716
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341021
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whesse @DartBot