Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedder lints not being configured. #25115

Closed
pq opened this issue Dec 4, 2015 · 2 comments
Closed

Embedder lints not being configured. #25115

pq opened this issue Dec 4, 2015 · 2 comments
Assignees
@pq
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@pq
Copy link
Member

pq commented Dec 4, 2015

For example, this flutter/lib/_embedder.yaml does not enable camel_case_types (as expected).

analyzer:
  strong-mode: true
  errors:
    strong_mode_static_type_error: false
    unused_local_variable: false
  language:
    enableSuperMixins: true
linter:
  rules:
    - camel_case_types
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter labels Dec 4, 2015
@pq pq self-assigned this Dec 4, 2015
@pq
Copy link
Member Author

pq commented Dec 4, 2015

Blocks: flutter/flutter#624.

@pq pq added the Type-Defect label Dec 4, 2015
@pq pq mentioned this issue Dec 7, 2015
Closed
@pq pq added the FixIt-15Q4 label Dec 7, 2015
pq added a commit that referenced this issue Dec 8, 2015
@pq
Embedded option processing fixes (#25115).
1e4cea3 
* Updates error filter and linter configuration to play nice with embedded options.
  * Fixes embedded lint config (#25115).
* Improves support for (and tests of) options file deletions.
* Pulls in linter with untyped options support (needed for processing merged options).

Unblocks: flutter/flutter#624.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1503353002 .
@pq
Copy link
Member Author

pq commented Dec 9, 2015

screen shot 2015-12-08 at 4 16 56 pm

🤘

Fixed w/ 1e4cea3.

@pq pq closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq