Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframe.contentDocument is accessible in dart:html frog. #2774

Closed
DartBot opened this issue Apr 27, 2012 · 13 comments
Closed

iframe.contentDocument is accessible in dart:html frog. #2774

DartBot opened this issue Apr 27, 2012 · 13 comments
Assignees
@vsmenon
Labels
closed-duplicate Closed in favor of an existing report P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
M1

Comments

@DartBot
Copy link

DartBot commented Apr 27, 2012

This issue was originally filed by podivilov@google.com

See dom/cross_frame_test contentDocument test.
@dgrove
Copy link
Contributor

dgrove commented Apr 27, 2012

Set owner to @vsmenon.
Added Area-DOM, Triaged labels.

@vsmenon
Copy link
Member

vsmenon commented Apr 27, 2012

Removed Priority-Medium label.
Added Priority-High label.

@DartBot
Copy link
Author

DartBot commented Apr 30, 2012

This comment was originally written by ngeoffray@google.com

dart2js now does not fail cross_frame_test. Was that bug only for dart2js or does it apply for others?

@vsmenon
Copy link
Member

vsmenon commented Apr 30, 2012

nicolas: i'm still seeing this marked as fail for dart2js. this is a dom api bug, so a pass on dart2js would probably a second bug at this point. will start investigating soon.

@vsmenon
Copy link
Member

vsmenon commented Apr 30, 2012

Marked this as blocking #2777.

@DartBot
Copy link
Author

DartBot commented May 1, 2012

This comment was originally written by ngeoffray@google.com

Maybe I'm confused whether it's a bug in the dom library or the html library. What I did, is remove the fail line in the dom.status file:

http://codereview.chromium.org/10261007/

@vsmenon
Copy link
Member

vsmenon commented May 2, 2012

Hi Nicolas, it's a bug in the html lib. There are two versions of this test:

dom/cross_frame_test
html/cross_frame_test

The former passes with both frog and dart2js. The latter fails on both. Thanks for fixing the status on the first.

Added Accepted label.

@vsmenon
Copy link
Member

vsmenon commented May 3, 2012

html/inner_frame_test (about to check in) also fails in a similar fashion. window.frameElement should not be accessible. w.document should be inaccessible when w is not the current frame. I am adding here instead of creating a new bug.

@vsmenon
Copy link
Member

vsmenon commented May 10, 2012

Unmarked this as blocking #-2777.

@vsmenon
Copy link
Member

vsmenon commented May 29, 2012

Issue #1174 has been merged into this issue.

@vsmenon
Copy link
Member

vsmenon commented May 29, 2012

I landed a simple fix for contentDocument and frameElement. I have a more robust solution under review (https://chromiumcodereview.appspot.com/10378040/), but it's currently on pause until we refactor the scripts.

@rakudrama
Copy link
Member

Added this to the M1 milestone.

@vsmenon
Copy link
Member

vsmenon commented Jun 22, 2012

Added Duplicate label.
Marked as being merged into #3836.

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures closed-duplicate Closed in favor of an existing report labels Jun 22, 2012
@DartBot DartBot added this to the M1 milestone Jun 22, 2012
@vsmenon vsmenon mentioned this issue Jun 3, 2015
Closed
dart-bot pushed a commit that referenced this issue Dec 7, 2020
@jonasfj
Roll pub
41381e9 
a7e448b2 pub upgrade --major-versions (#2784)
06bcff09 pub upgrade foo, only unlocks foo from pubspec.lock (#2781)
aa20a4bd Usage exceptions no stacktrace (#2776)
14e12bf6 Clarify error message when spawning a subprocess fails (#2763)
5ef0a0e7 Added a pub upgrade --nullsafety mode (#2741)
9cde2406 Fix pub remove --dry-run (#2774)
7426be94 Remove hack now issue has been fixed (#2773)
90a1f776 Limit retries in test to avoid timeout (#2765)
3aa327c7 Stop depending on .packages (#2764)

Change-Id: Ifd8a8402c4628e7278b6fedfd2ca7902004fa6e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175241
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
dart-bot pushed a commit that referenced this issue Dec 8, 2020
@davidmorgan
Revert "Roll pub"
c0e13c1 
This reverts commit 41381e9.

Reason for revert: pub fails on startup if git is not installed; b/175080640

Original change's description:
> Roll pub
>
> a7e448b2 pub upgrade --major-versions (#2784)
> 06bcff09 pub upgrade foo, only unlocks foo from pubspec.lock (#2781)
> aa20a4bd Usage exceptions no stacktrace (#2776)
> 14e12bf6 Clarify error message when spawning a subprocess fails (#2763)
> 5ef0a0e7 Added a pub upgrade --nullsafety mode (#2741)
> 9cde2406 Fix pub remove --dry-run (#2774)
> 7426be94 Remove hack now issue has been fixed (#2773)
> 90a1f776 Limit retries in test to avoid timeout (#2765)
> 3aa327c7 Stop depending on .packages (#2764)
>
> Change-Id: Ifd8a8402c4628e7278b6fedfd2ca7902004fa6e8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175241
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>

TBR=sigurdm@google.com,jonasfj@google.com

Change-Id: I29b20b4a2dc037146dd27c8fe6e6ecce6833e7b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175303
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
dart-bot pushed a commit that referenced this issue Dec 9, 2020
@sigurdm
Reland "Roll pub"
bf26eb3 
This is a reland of 41381e9

Contains one more fix:
8ea96121d fix tryGitCommand

Original change's description:
> Roll pub
>
> a7e448b2 pub upgrade --major-versions (#2784)
> 06bcff09 pub upgrade foo, only unlocks foo from pubspec.lock (#2781)
> aa20a4bd Usage exceptions no stacktrace (#2776)
> 14e12bf6 Clarify error message when spawning a subprocess fails (#2763)
> 5ef0a0e7 Added a pub upgrade --nullsafety mode (#2741)
> 9cde2406 Fix pub remove --dry-run (#2774)
> 7426be94 Remove hack now issue has been fixed (#2773)
> 90a1f776 Limit retries in test to avoid timeout (#2765)
> 3aa327c7 Stop depending on .packages (#2764)
>
> Change-Id: Ifd8a8402c4628e7278b6fedfd2ca7902004fa6e8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175241
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>

Change-Id: Id50e6eca0372860f7087882a5c67141def07031c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175309
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

Labels
closed-duplicate Closed in favor of an existing report P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
M1
Development

No branches or pull requests
4 participants
@dgrove @rakudrama @vsmenon @DartBot