-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Every object is null
when using Dartium 50, WebStorm 2017.1.2 on Windows 10
#29854
Comments
and 2017.1.4 on Mac |
Can you investigate on the WebStorm side on what you're not getting from Dartium? For most objects I'm seeing null, scalars (strings, ints, etc. are valid), many dart:html items like button, div seem to appear too. However, many others are null. A good simple example to try is from the https://github.com/dart-lang/dart-tutorials-samples Setting a BP on the generateNewLetters(); line in the function: void newletters(Event e) { will show both this and e as null? |
@terrylucas I know before the roll you tested it against IJ, which version and platform works? Also, is the issue presenting itself in the Webstorm 2017.2 EAP or Ultimate 2017.2 EAP? FYI: Alex is out on vacation next week. |
Tested to make sure BPs worked (and some variables do display values) however it looks like others do not. I also tried with 2017.2 EAP and it fails the same way. In particular, in the anagram example the instance for e displays as null. |
I'm OOO till June, 26. The first step is to see what Dartium sends to the IDE, maybe it is sending nulls instead of real var values. To get these logs click Help -> Find Action, type |
@terrylucas @jwren I compared debug logs and see some difference between Dartium 1.23 and 1.24.1 that I think leads to nulls as var values. I played with the anagram project and a single breakpoint in |
@alexander-doroshko Thanks for looking into the issue. I am not familiar with the protocol requirements/ expectations either. |
Thanks Alexander I found the same thing. Its looks like for subtype that
its a new part of the Protocol (whether it should be null I not sure), as
for nested value I'm not sure but I've started debugging it.
…On Fri, Jun 16, 2017 at 1:14 PM, Alexander Doroshko < ***@***.***> wrote:
@terrylucas <https://github.com/terrylucas> @jwren
<https://github.com/jwren> I compared debug logs and see some difference
between Dartium 1.23 and 1.24.1 that I think leads to nulls as var values.
I played with the anagram project and a single breakpoint in void
newletters(Event e). Note that this is expected to be null, but e - not,
it is expected to be MouseEvent. IDE sends "Runtime.getProperties"
request and receives "handleResult" event. The difference is that the
response from Dartium 1.24.1 includes "value":null for the e variable,
but response from Dartium 1.23 doesn't contain "value" attribute at all.
See attached screenshot. I'm not an expert in the protocol so can't say for
sure whether it is a Dartium fault or IDE incorrectly interprets the
response or both. I'll be able to ask colleagues after vacation unless you
know the answer.
[image: image]
<https://user-images.githubusercontent.com/4499789/27243189-6c771e92-52e9-11e7-816e-5f2740c2ecbf.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29854 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB9ewRnGEsJlDlPqxbABksJD0e_XlDSPks5sEuIvgaJpZM4N4aqa>
.
|
Have a fix for this CL |
- Fix DevConsole crash with JS see Issue #29873 CL https://codereview.chromium.org/2941143002 - Fix debugging in WebStorm, NULL returned for JS objects see Issue #29854 CL https://codereview.chromium.org/2945063002 TBR=jacobr@google.com Review-Url: https://codereview.chromium.org/2952643002 .
- Fix DevConsole crash with JS see Issue #29873 CL https://codereview.chromium.org/2941143002 - Fix debugging in WebStorm, NULL returned for JS objects see Issue #29854 CL https://codereview.chromium.org/2945063002 TBR=jacobr@google.com Review-Url: https://codereview.chromium.org/2952643002 .
Released in 1.24.2 stable |
I've seen this behavior on 2 machines. Rolling back Dartium works.
The text was updated successfully, but these errors were encountered: