-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows filenames versus URI/URL #312
Comments
This is fixed now that the URI handling in imports has been rewritten. Output from a recent test failure on the Windows buildbot: Unhandled exception: Set owner to @iposva-google. |
I have filed issue #6 to track handling of //. |
Closure compiler chokes on super classes that aren't qualified paths. (example: http://goo.gl/5mHC7S) BUG= R=jmesserly@google.com Review URL: https://codereview.chromium.org/1638533004 .
…or Closure, to avoid ES5->ES6 lowering bug (google/closure-compiler#1460). This is part of the overall "simple closure" effort (issue #312) BUG= R=jmesserly@google.com Review URL: https://codereview.chromium.org/1630963003 .
This is not about the error below. This is about the formatting of the stack trace on Windows as illustrated by the error message below.
Consider the first two lines of of the stack trace:
0. Function: '_File@689f3ad.openSync' url: './dart:builtin-lib' line:857 col:7
1. Function: 'FileTest.testReadWriteSync' url: 'e:\b\build\slave\vm-win32-release\build\tests\standalone\src\FileTest.dart' line:201 col:18
Notice these parts in particular:
url: './dart:builtin-lib'
url: 'e:\b\build\slave\vm-win32-release\build\tests\standalone\src\FileTest.dart'
The first is correct, the second contains a Windows file name that can be represented correctly as a URI using this form:
file:///E:/b/build/slave/vm-win32-release/build/tests/standalone/src/FileTest.dart
See: http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx
Since Dart lives in a world where URI/URL are important and used all the time, I would consider if the basic abstraction should be URIs, not platform dependent filenames.
The example error message is from:
=== releaseia32 vm standalone/FileTest ===
Path: standalone/FileTest
--- stderr ---
An unhandled exception has been thrown
FileIOException: Cannot open file: runtime/tests/vm/data/fixed_length_file_out
0. Function: '_File@689f3ad.openSync' url: './dart:builtin-lib' line:857 col:7
1. Function: 'FileTest.testReadWriteSync' url: 'e:\b\build\slave\vm-win32-release\build\tests\standalone\src\FileTest.dart' line:201 col:18
2. Function: 'FileTest.testMain' url: 'e:\b\build\slave\vm-win32-release\build\tests\standalone\src\FileTest.dart' line:540 col:39
3. Function: 'main' url: 'e:\b\build\slave\vm-win32-release\build\tests\standalone\src\FileTest.dart' line:555 col:20
Command: e:\b\build\slave\vm-win32-release\build\runtime\Release_ia32\dart_bin --ignore-unrecognized-flags --optimize e:\b\build\slave\vm-win32-release\build\tests\standalone\src\FileTest.dart
The text was updated successfully, but these errors were encountered: