Tracking issue for removal of deprecated SDK constant names

[leafpetersen]

The old all caps names for constants in the SDK have been deprecated in favor of camel case versions. This issue tracks the removal of the of old deprecated names.

TODO:

• Implement tooling Implement tooling for migrating code away from deprecated Dart 1.0 constant names #31822
• Follow up on breaking change announcement
• Clean up flutter and internal package dependencies
  • Remove uses of deprecated constants from packages used by flutter and internal code  #32749
• Clean up flutter code (if required)
• Clean up internal code
• Remove deprecated constants

This is part of the larger Dart 2.0 corelib changes tracked here: #31812 .

[Hixie]

As part of this we should have a script that automatically ports old code. We should use that to port Flutter, as a proof of concept. We should then hook that script into flutter upgrade to upgrade everyone's code.

[leafpetersen]

I'll file an issue for that. We may want to consider whether we can do that for at least some of the wave 3 changes as well.

[matanlurey]

The difficulty is this would (likely) require analysis-driven refactoring.

We have an internal tool that is near completion for this task. We could spend a couple weeks and open source it, but this needs to be a P1 directive and coordinated ASAP, and not just be a "oh it's <some date>, we need it <this week>".

[leafpetersen]

@Hixie @mit-mit is this something we should aim to have done by March 1st, or (assuming we have an automated migration path) is this something that can be pushed into Q2?

[Hixie]

It's something we should have before we remove the uppercase constants; I'm not aware of anything that's driving us to remove them by a particular date.

[leafpetersen]

cc @lrhn @anders-sandholm @keertip @grouma @matanlurey @srawlins @vsmenon @dgrove @kevmoo

[leafpetersen]

@Hixie Is the infrastructure for upgrading user code via flutter upgrade built out already? That is, is there an existing system which identifies user files to be updated etc can just call out to an appropriate tool? Or does all of that need to be figured out as part of this?

[Hixie]

@xster was working on something related to this, not sure how far he got. @xster?

[leafpetersen]

Fix it package here: https://pub.dartlang.org/packages/dart2_fix

[dgrove]

When is the next step for this?

[leafpetersen]

I'll prepare some docs and an announcement email and follow up on the relevant email lists today.

[dgrove]

What's the next step here, @leafpetersen ?

[leafpetersen]

@lrhn is going to coordinate this. @zanderso is working on the dart:io part of this. @keertip will handle internal code. @devoncarew will update dart2_fix once we have the list of dart:io renames.

[dgrove]

dart:io is complete. What is remaining?

[lrhn]

Removal of usages in packages.
I have the non-dart:io constants removed from all SDK package dependencies. Now it's the rest of the world.
Google code can remove the constants at any time, but it'll be easier if we have a compilable CL for the SDK which removes the declarations.

[leafpetersen]

Once we have a roll to flutter this can be closed.

[leafpetersen]

We've rolled flutter, this is done.

[natebosch]

Why did we close this? The deprecated constants in at least dart:io still exist. Do we have another issue open to track their removal in Dart 3.0?

sdk/sdk/lib/_http/http.dart

Line 568 in 55aa031

static const ACCEPT = acceptHeader;

[kevmoo]

https://api.dartlang.org/stable/2.0.0/dart-io/HttpHeaders-class.html That's...embarrassing...

…

On Tue, Aug 21, 2018 at 3:54 PM Nate Bosch ***@***.***> wrote: Reopened #31813 <#31813>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31813 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCin3W5-Wyen_fN6QruQx4eUEpyzfBks5uTI-kgaJpZM4RYUGG> .

[devoncarew]

Given the expense of deleting the deprecated sdk constants, and relatively low user value to deleting them, I don't think we should delete the dart:io constants.

I think it would make sense to close this issue as covering the non-dart:io constant deletion for Dart 2.0, and open a new issue to determine what if anything we should do with the dart:io constants.

[natebosch]

SGTM considering non-dart:io constants complete and opening a new issue for dart:io constant.