Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis server does not report problems when it fails #3207

Closed
keertip opened this issue May 24, 2012 · 3 comments
Closed

Analysis server does not report problems when it fails #3207

keertip opened this issue May 24, 2012 · 3 comments
Assignees
@danrubel
Labels
closed-obsolete Closed as the reported issue is no longer relevant
Milestone
M1

Comments

@keertip
Copy link
Contributor

keertip commented May 24, 2012

 - Open Slider sample in the editor

 - slider_sample.dart
     #import('../ui_lib/view/view.dart'); => #import('package:view/view.dart');

  • save file. I can see compilation errors cant resolve package: etc.
  • Preferences set package root to point to /USER_PATH/samples/ui_lib/
  • compile errors go away, but try to edit slider_sample and save, the operation throws DartModelException

This is because view.dart contains relative imports that are not being resolved to the right location. Unfortunately there is no indication that the analysis ran into problems or that it could not find the files needed.
@keertip
Copy link
Contributor Author

keertip commented May 24, 2012

Sorry, wrong instructions to repro

 #import('../ui_lib/view/view.dart'); => #import('package:ui_lib/view/view.dart');

and Preferences set package root to point to /USER_PATH/samples/

@danrubel
Copy link

danrubel commented Jun 5, 2012

Added this to the M1 milestone.

@dgrove
Copy link
Contributor

dgrove commented Oct 10, 2012

This appears to be working fine now.

Added AssumedStale label.

@keertip keertip added Type-Defect closed-obsolete Closed as the reported issue is no longer relevant labels Oct 10, 2012
@keertip keertip added this to the M1 milestone Oct 10, 2012
copybara-service bot pushed a commit that referenced this issue Dec 1, 2021
@jonasfj
Bump pub to dcb6abac2d7d43258c03b348be42bf4aab9529b1
780bc26 
Changes:
```
> git log --format="%C(auto) %h %s" b9edfa5..dcb6aba
 https://dart.googlesource.com/pub.git/+/dcb6abac Merge remote-tracking branch 'origin/cherry-pick2-for-2.15.0'
 https://dart.googlesource.com/pub.git/+/dc857523 Remove duplicated lines in testdata (#3234)
 https://dart.googlesource.com/pub.git/+/acc8ab09 Refactor the test package-server (#3230)
 https://dart.googlesource.com/pub.git/+/1e78c688 Better error messages round 2 (#3223)
 https://dart.googlesource.com/pub.git/+/eaf36513 More links in the repository specification (#3220)
 https://dart.googlesource.com/pub.git/+/c888b018 Remove pedantic and cleanup a few lints (#3224)
 https://dart.googlesource.com/pub.git/+/a4d44c7e Global package server null safety (#3225)
 https://dart.googlesource.com/pub.git/+/ff941887 Merge branch 'cherry-pick-for-2.15.0'
 https://dart.googlesource.com/pub.git/+/efd24e64 Fix hanging event handler for `stdin`. (#3218)
 https://dart.googlesource.com/pub.git/+/d77c14e8 Gitignore validator should not follow symlink dirs (#3209)
 https://dart.googlesource.com/pub.git/+/7c190789 migrate rest of test/ to null-safety (#3207)
 https://dart.googlesource.com/pub.git/+/f24adb64 migrate test/oath2/ test/outdated/ test/token test/validator/ to null-safety (#3206)
 https://dart.googlesource.com/pub.git/+/e7d77a57 migrate test/add, test/cache, test/embedding plus a bit more to null-safety (#3205)
 https://dart.googlesource.com/pub.git/+/a6a73ad2 migrate test/lish/, test/run/, test/upgrade/ and golden_file.dart to null-safety (#3204)
 https://dart.googlesource.com/pub.git/+/b90efc1f Add test that `pub get` works with no $HOME in environment. (#3173)
 https://dart.googlesource.com/pub.git/+/c2fe3966 migrate test/get/ to null-safety (#3203)
 https://dart.googlesource.com/pub.git/+/1d106898 migrate test/hosted/ to null-safety (#3200)
 https://dart.googlesource.com/pub.git/+/afa9932b migrate test/cache and test/downgrade/ to null-safety (#3201)
 https://dart.googlesource.com/pub.git/+/352ca989 migrate test/global/ to null-safety (#3202)
 https://dart.googlesource.com/pub.git/+/64f20ca4 migrate test/descriptor/ and couple more files in test/ to null-safety (#3192)

```

Diff: https://dart.googlesource.com/pub.git/+/b9edfa5e288ea3d1a57d1db054ef844ae7b27d99~..dcb6abac2d7d43258c03b348be42bf4aab9529b1/
Change-Id: I30d33b0b8c3c19097a16543db15c6ae633f0afc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221633
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 4, 2022
Roll Dart Documentation Generator from 71545cdf2e5c to 9908cf86dd66 (…
9a53b32 
…2 revisions)

https://dart.googlesource.com/dartdoc/+log/71545cdf2e5c..9908cf86dd66

2022-10-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.8 to 3.0.10 (#3207)
2022-10-04 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.24 to 2.1.26 (#3206)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: I6a2ac667e98c93879d05ad2f62239fc438726941
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262641
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrubel danrubel

Labels
closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
M1
Development

No branches or pull requests
3 participants
@dgrove @keertip @danrubel