timeout_test.dart does not terminate correctly on Mac OS X

[ghost]

After running tests on Mac OS X, timeout test leaves zombie processed:

xcodebuild/Debug_x64/dart --ignore-unrecognized-flags --enable_type_checks ../tests/standalone/timeout_test.dart

[whesse]

The timeout test is not supposed to terminate when run directly. This lets us test the capacity of the test scripts to detect non-terminating tests, and terminate them.
It should be marked as Skip in the status file, and only run from the test_runner_test.dart.

But since this issue keeps coming up, I will change timeout test to run for 30 seconds, then terminate. That is sufficient for our purposes. I could also make it take the time to run for as a command-line argument. Then when run without an argument, it would terminate completely.

[iposva-google]

Bill, I don't think Srdjan is running the timeout_test directly. I think the issue is more that if the test_runner_test does not finish correctly, then it will not cleanly kill the timeout_test and you end up with spinning processes.

[ghost]

Yes, Ivan is correct. The timeout test does not terminate when run as part of the test harness (tools/test.py).

[ghost]

Can we disable the test until this bug has been resolved?

[iposva-google]

I have seen this also happening on Linux. If test_runner_test.dart fails then you end up with runaway processes on your machine. Updating this bug to Critical and disabling test_runner_test.dart until then.

---

Removed Priority-Medium label.
Added Priority-Critical, Accepted labels.

[whesse]

The problem of a runaway process has been fixed, in r8315. A new flake has showed up, that the test of running a failing process in test_runner_test timed out, instead of failing. Since we are running with a very low timeout of 2 seconds, perhaps that is not always enough time to start up a new dart process, and fail. Investigating.

[whesse]

The main issue has been fixed, and I have not seen a recurrence of the timeout on fail_test. Marking as fixed.

---

Added Fixed label.