-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to name isolates for debugging #34059
Comments
Would we consider adding an optional |
If we only add it to the static methods |
Another suggestion from a while ago is to be able to set it from the |
Fixes issue #34059 Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
…isolates." This reverts commit 5952526. Reason for revert: causes Flutter test observatory and protocol to deadlock. Issue: #36232 Original change's description: > [ VM / dart:isolate ] Added ability to set names for spawned isolates. > > Fixes issue #34059 > > Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341 > Commit-Queue: Ben Konyi <bkonyi@google.com> > Reviewed-by: Sigmund Cherem <sigmund@google.com> > Reviewed-by: Ryan Macnak <rmacnak@google.com> TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com,sigmund@google.com Change-Id: I5f2115a2ac394a8d4c7c175bc97f2b88b65fcb49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97107 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
In flutter/flutter#19490 @rmacnak-google said "the framework's use of wrapper functions makes it impossible to tell just from the isolate's name". It would be great if we could provide information to
Isolate.spawn
to make future debugging easier, since we actually have name information at hand when we make that call (we use it in Timeline calls). (I'm not sure where the Isolate's name appears, but presumably in debugging dumps or some such?)The text was updated successfully, but these errors were encountered: