Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js should implement show: and hide: combinators #3454

Closed
gbracha opened this issue Jun 8, 2012 · 6 comments
Closed

dart2js should implement show: and hide: combinators #3454

gbracha opened this issue Jun 8, 2012 · 6 comments
Assignees
Milestone

Comments

@gbracha
Copy link
Contributor

gbracha commented Jun 8, 2012

Per spec, section 12.2

Language issue #817

@kasperl
Copy link

kasperl commented Sep 3, 2012

Set owner to @johnniwinther.
Added this to the M1 milestone.

@kasperl
Copy link

kasperl commented Oct 11, 2012

Fixed in r13534.


Added Fixed label.

@efortuna
Copy link
Contributor

This still needs a little work. Try running it in firefox on Windows. It fails. :-(


Added Triaged label.

@efortuna
Copy link
Contributor

This still needs a little work. Try running it in firefox on Windows. It fails. :-(

@kasperl
Copy link

kasperl commented Oct 12, 2012

The log file that shows the error is here:

http://build.chromium.org/p/client.dart/builders/dart2js-ff-win7/builds/363/steps/dart2js%20tests/logs/stdio

It says:


@@@STEP_CLEAR@@@
@@@STEP_TEXT@ 55% +489 -0 @­@@

  1. build\ReleaseIA32\dart-sdk\bin\dart2js.bat --out=e:/b/build/slave/dart2js-ff-win7/build/dart/build/ReleaseIA32/generated_tests/dart2js-ff/tests_language_import_core_no_prefix_test/test.js e:/b/build/slave/dart2js-ff-win7/build/dart/build/ReleaseIA32/generated_tests/dart2js-ff/tests_language_import_core_no_prefix_test/test.dart
  2. python e:\b\build\slave\dart2js-ff-win7\build\dart\tools\testing\run_selenium.py --browser=ff --timeout=478 --out=e:/b/build/slave/dart2js-ff-win7/build/dart/build/ReleaseIA32/generated_tests/dart2js-ff/tests_language_import_core_no_prefix_test/test.html
    language/import_combinators_test
    test.dart: Compilation failed (step 1 of 2), exit code 1

pkg/unittest/html_config.dart:8:10: Warning: duplicated library name "'unittest'".
#library('unittest');
         ^^^^^^^^^^
pkg/unittest/unittest.dart:137:10: Warning: duplicated library name "'unittest'".
#library('unittest');
         ^^^^^^^^^^
tests/language/import_combinators_test.dart:7:1: library tags not allowed here
import "import1_lib.dart" show hide, show hide ugly;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Compilation failed.

FAILED: dart2js-ff release_ia32 language/import_combinators_test
Expected: pass
Actual: fail
Unexpected compile-time error.


Added Started label.

@peter-ahe-google
Copy link
Contributor

This problem is fixed. Wrapping tests is what is broken. See issue #2264.


Added Fixed label.

@gbracha gbracha added this to the M1 milestone Oct 12, 2012
copybara-service bot pushed a commit that referenced this issue Jun 29, 2023
…uf, test

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/e04a6b3..c2ed703):
  c2ed703c  2023-06-26  dependabot[bot]  Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#3454)

ecosystem (https://github.com/dart-lang/ecosystem/compare/b1056e6..19fa443):
  19fa443  2023-06-29  Lasse R.H. Nielsen  Clean-up and tweaks of the firehose project. (#117)
  9ef5948  2023-06-27  Moritz  Excise health from firehose (#118)
  36c662e  2023-06-27  Moritz  Introduce a health checking workflow (#115)

http (https://github.com/dart-lang/http/compare/ff1fcfe..d68081f):
  d68081f  2023-06-26  Nate Bosch  Prepare to publish package:http (#973)
  067bff3  2023-06-26  Alex James  Create java http package (#971)

lints (https://github.com/dart-lang/lints/compare/79581ff..89f9519):
  89f9519  2023-06-28  Parker Lougheed  Fix typo in 3.0.0-wip changelog entry (#137)

markdown (https://github.com/dart-lang/markdown/compare/bd6ae8d..4674d09):
  4674d09  2023-06-27  Zhiguang Chen  Fix HtmlBlockSyntax (#548)

mockito (https://github.com/dart-lang/mockito/compare/1d6064a..974226e):
  974226e  2023-06-27  Googler  Internal change

protobuf (https://github.com/dart-lang/protobuf/compare/e76bd74..7bebbc6):
  7bebbc6  2023-06-29  Ömer Sinan Ağacan  Update protoc_plugin Makefile: (#858)
  acc0462  2023-06-29  Ömer Sinan Ağacan  Ignore non-items in message sets (#857)
  0eb3796  2023-06-29  Ömer Sinan Ağacan  Ignore unknown tags in message set items (#856)
  2996e1d  2023-06-27  Ömer Sinan Ağacan  Implement message set wire format (#836)

test (https://github.com/dart-lang/test/compare/cdc8178..021667a):
  021667a4  2023-06-28  Jacob MacDonald  prep to release (#2048)
  3d44fcae  2023-06-28  Yaroslav Vorobev  feat(test): add MOZ_AUTOMATION=1 to ff test runner (#2049)
  6e675f80  2023-06-28  Parker Lougheed  Replace broken link to observatory with DevTools mention (#2047)
  2904779b  2023-06-28  Yaroslav Vorobev  feat(runner): add env overrides for safari and ff (#2042)
  54350282  2023-06-28  Parker Lougheed  Update link from old linter site to dart.dev (#2046)
  8c4b15d1  2023-06-28  Jacob MacDonald  allow the latest analyzer (6.x.x) (#2045)

Change-Id: I86901fb2211adf81288f0940a355d6c33ddd8a7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311927
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants